Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable @defer support #122

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

calvincestari
Copy link
Member

Turning off defer support in main until the implementation is complete. This will be merged into #121 before that PR is merged into main.

@AnthonyMDev
Copy link
Contributor

Did you forget to push your commits to the remote branch? This only removes the docs page from the nav bar.

@calvincestari
Copy link
Member Author

Did you forget to push your commits to the remote branch? This only removes the docs page from the nav bar.

Nope, it's simply not done yet

@AnthonyMDev AnthonyMDev marked this pull request as draft November 2, 2023 19:05
@AnthonyMDev
Copy link
Contributor

Okay, no problem. I'm going to convert this to draft in the mean time then.

@calvincestari
Copy link
Member Author

Ready for review now with 4c89d65.

@calvincestari calvincestari marked this pull request as ready for review November 2, 2023 19:48
@calvincestari calvincestari merged commit eb70a4a into feature/defer Nov 2, 2023
@calvincestari calvincestari deleted the defer/prepare-merge-to-main branch November 2, 2023 21:17
BobaFetters pushed a commit that referenced this pull request Nov 2, 2023
f499efa4 chore: Disable `@defer` support (#122)
70fd68cd Merge branch 'main' into feature/defer
d6c49617 Defer Selection Set Template - Basic (W/clean up) (#118)
f5dc1758 merge: `feature/defer` update to `main` (#116)
2c5463b0 refactor: [1/x] Refactor root field builder for deferred fragments (#74)
25d44b83 Merge branch 'main' into feature/defer
1d8424d3 Merge branch 'main' into feature/defer
a8c31ca3 Merge branch 'main' into feature/defer
d1a3c0ab feature: Operation definition template supports the `@defer` directive (#31)
6a01891b Merge branch 'project-breakup' into feature/defer
11cf5828 Merge branch 'project-breakup' into feature/defer
723b8648 refactor: Don't require `label` argument for deferred named fragments (#33)
9041eee0 feature: Require `label` argument on `@defer` directive (#28)
01b81541 Migrating defer branch to new project structure

git-subtree-dir: apollo-ios-codegen
git-subtree-split: f499efa4ee99c7eb86e5f2e6d0b630756c48f0de
calvincestari added a commit that referenced this pull request Nov 3, 2023
@infotracktechnology
Copy link

@calvincestari not able fork this repo

@calvincestari
Copy link
Member Author

@infotracktechnology - there is no policy for this specific repo to disallow forking. I believe we have that controlled at the organizational level and all of our OSS repos should allow forking. If you can fork any of the other Apolo OSS repos then you should be able to fork this one too.

@infotracktechnology
Copy link

Thanks

calvincestari added a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants