-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating contributing guides #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left one inline suggestion to add a link to our Discord server :)
Co-authored-by: Jeff Auriemma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think all this information here is great, I do think the way it's organized makes it difficult to quickly understand what you need to do.
It should be immediately clear that PRs and development should occur in the Apollo iOS Dev repo, while all bugs, feature requests, and other issues should be in Apollo iOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a minor nitpick addition.
Updated the contributing guides for
apollo-ios
andapollo-ios-codegen
to point to the contributing guide forapollo-ios-dev
. Updated the main contributing guide to breakdown the purpose and use of each of the repositories.