Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating contributing guides #23

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

BobaFetters
Copy link
Member

Updated the contributing guides for apollo-ios and apollo-ios-codegen to point to the contributing guide for apollo-ios-dev. Updated the main contributing guide to breakdown the purpose and use of each of the repositories.

Copy link
Contributor

@bignimbus bignimbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one inline suggestion to add a link to our Discord server :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Jeff Auriemma <[email protected]>
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think all this information here is great, I do think the way it's organized makes it difficult to quickly understand what you need to do.

It should be immediately clear that PRs and development should occur in the Apollo iOS Dev repo, while all bugs, feature requests, and other issues should be in Apollo iOS.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a minor nitpick addition.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
apollo-ios-codegen/CONTRIBUTING.md Outdated Show resolved Hide resolved
apollo-ios/CONTRIBUTING.md Outdated Show resolved Hide resolved
@BobaFetters BobaFetters merged commit e36b11a into project-breakup Sep 1, 2023
@BobaFetters BobaFetters deleted the docs/contributing-guide branch September 1, 2023 14:19
BobaFetters added a commit that referenced this pull request Sep 1, 2023
BobaFetters added a commit to apollographql/apollo-ios that referenced this pull request Sep 1, 2023
BobaFetters added a commit to apollographql/apollo-ios-codegen that referenced this pull request Sep 1, 2023
BobaFetters pushed a commit that referenced this pull request Sep 1, 2023
7426485 Updating contributing guides (#23)

git-subtree-dir: apollo-ios
git-subtree-split: 7426485
BobaFetters pushed a commit that referenced this pull request Sep 1, 2023
git-subtree-dir: apollo-ios
git-subtree-mainline: 335653a
git-subtree-split: 7426485
BobaFetters pushed a commit that referenced this pull request Sep 1, 2023
48b6461 Updating contributing guides (#23)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 48b6461
BobaFetters pushed a commit that referenced this pull request Sep 1, 2023
git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: 97618d5
git-subtree-split: 48b6461
BobaFetters added a commit to apollographql/apollo-ios-codegen that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants