fix: Disfavour deprecated watch
function
#469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
watch(query:cachePolicy:context:callbackQueue:resultHandler:)
function was deprecated the new function introduced a single new parameter with a default which meant that using the minimally required parameters to call the function (watch(query:resultHandler:)
) matches both signatures. This generates a perpetual deprecation warning with no way to get rid of it other than to use the newrefetchOnFailedUpdates
parameter in the function call.Marking the deprecated function with
@_disfavoredOverload
allows the minimally required function call to be used again without the deprecation warning. I'm really surprised that nobody has complained about this before.