Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApolloCodegenLib doesn't include an equivalent option for customScalarsPrefix #1214

Closed
CraigSiemens opened this issue May 18, 2020 · 2 comments · Fixed by #1216
Closed

ApolloCodegenLib doesn't include an equivalent option for customScalarsPrefix #1214

CraigSiemens opened this issue May 18, 2020 · 2 comments · Fixed by #1216
Labels
codegen Issues related to or arising from code generation
Milestone
0.28.0

Comments

@CraigSiemens
Copy link
Contributor

I'm trying out the codeine using SPM and I've found that the flag --customScalarsPrefix that we've been using is not available.

We use the --passthroughCustomScalars flag to define out own types for the scalars, and --customScalarsPrefix="Scalar." to prevent name conflicts between scalars and Foundation types. For example Scalar.Date is using a custom struct for year, month, day and shouldn't conflict with Foundation.Date
@designatednerd
Copy link
Contributor

Ah yeah, will get that added in

@designatednerd designatednerd added the codegen Issues related to or arising from code generation label May 18, 2020
@designatednerd designatednerd mentioned this issue May 19, 2020
Closed
@designatednerd designatednerd added this to the Next Release milestone May 19, 2020
@designatednerd
Copy link
Contributor

@CraigSiemens PR #1215 is up

@CraigSiemens CraigSiemens mentioned this issue May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen Issues related to or arising from code generation
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

Added option to generate a custom scalar with a prefix. CraigSiemens/apollo-ios
2 participants
@CraigSiemens @designatednerd