Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing custom scalars prefix to Swift codegen #1215

Closed
wants to merge 1 commit into from
Closed

Add missing custom scalars prefix to Swift codegen #1215

wants to merge 1 commit into from

Conversation

designatednerd
Copy link
Contributor

Addresses #1214.

@designatednerd designatednerd added this to the Next Release milestone May 19, 2020
@designatednerd designatednerd mentioned this pull request May 19, 2020
Closed
@CraigSiemens
Copy link
Contributor

CraigSiemens commented May 19, 2020 •
edited
Loading

I took a stab at making this change as well, though I took a slightly different approach of adding an enum for the CustomScalarFormat. I should have posted in the issue that I'd try to fix it. I'm not sure wether to make a PR for it now or not. You can take a look at my change if you'd like.

Edit: I've posted my PR here #1216. Feel free to close or accept, I'm fine with either solution.

@CraigSiemens CraigSiemens mentioned this pull request May 19, 2020
Merged
@designatednerd designatednerd removed this from the Next Release milestone May 19, 2020
@designatednerd
Copy link
Contributor Author

Closing in favor of #1216.

@designatednerd designatednerd deleted the add/option branch May 19, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@designatednerd @CraigSiemens