Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delegate from HTTPNetworkTransport initializer #1002

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

designatednerd
Copy link
Contributor

Suggested by @RolandasRazma in #990, let's make this a fully breaking change to the delegate so people are more clearly ware of the change.

Also I think I might have figured something out with one of the tests that keeps failing as part of #993, so I threw that fix in here.

Verified

This commit was signed with the committer’s verified signature.
doppins-bot Doppins

Verified

This commit was signed with the committer’s verified signature.
doppins-bot Doppins
@@ -473,5 +473,8 @@ class FetchQueryTests: XCTestCase {
}
self.wait(for: [expectation], timeout: 10)

for watcher in watchers {
watcher.cancel()
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a sneaking suspicion that the watchers are getting overcalled because they're not necessarily getting killed off by ARC in time to avoid calls from other tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if its the case here, but we had to add to wrap to autoreleasepool { ... } to workaround ARC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what'd you need to add that to?

@designatednerd designatednerd added this to the 0.22.0 milestone Feb 5, 2020
@designatednerd designatednerd merged commit 134bd48 into master Feb 6, 2020
@designatednerd designatednerd deleted the update/weakity branch February 6, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants