-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 12 + iOS 14 + Swift 5.3 + associated Updates #1280
Conversation
d1066da
to
f015b4f
Compare
Thanks for this. When using Carthage + Xcode 12 Beta 1 to build Apollo, I ran into a few issues. I think there is something wrong in the beta with the
|
Hey @danl3v - Thanks for the heads up. On Apollo, how did you determine those issues? I am not seeing warnings at any of the places you've changed the code. |
We are a version or two back. If you pull down |
199e963
to
c299115
Compare
c299115
to
7a176e6
Compare
dbf815e
to
22a4d88
Compare
I checked on 0.29.1 and am still not able to build with Carthage. Fixes here for 0.29.1: https://github.com/danl3v/apollo-ios/tree/0.29.1-xcode12 |
@danl3v Can you please try with Xcode 12 beta 3? Thank you! |
Sure can do. Will be next week since I am out the rest of the week. Will report back here |
07b65f7
to
851856d
Compare
ca4b06a
to
62fda0f
Compare
Hey @designatednerd - I'm not that familiar with SwiftPM, but it seems to have trouble handling updates to this branch made via force push (and sadly, Xcode's error message here is not very helpful):
Possible there's a better way to approach this - for now we just manually update |
I suppose that makes sense because when rebasing it updates all the commit hashes, and the hash that was pinned by the I think long term I still want to keep rebasing rather than merging because it'll make the changeset way less insane when I do merge all this, but I appreciate you posting here so people see this and know how to resolve the issue! |
d34ebc7
to
b0ae59b
Compare
To follow up when archiving apollo with Xcode 12 betas, beta 4 fixes the issue for me. Thanks for the support! |
b0ae59b
to
a4a974a
Compare
9790166
to
2642e18
Compare
LOL I guess nobody told the SDK team they were going with 11.0
this one goes to eleven
2642e18
to
3523002
Compare
Good news: This branch is working fine on Intel hardware if you need to integrate it immediately |
…tings (supposedly)
I'm going to open a new issue on the Apple Silicon problems and merge this - at this point nobody has silicon macs yet and people need to be able to release tomorrow. |
This branch is where updates for Xcode 12, Swift 5.3, iOS/tvOS 14, watchOS 7, and macOS 11 will live until it comes out of beta. Thus far it includes [will try to keep this up to date]:
If you've got a bugfix or a feature specific to Xcode 12 or the associated Swift/OS versions, please open a PR against this branch rather than against
main
. This branch will not be merged tomain
until the final version of Xcode 12 is released.