Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose cacheKey function as public #2014

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Expose cacheKey function as public #2014

merged 2 commits into from
Nov 3, 2021

Conversation

calvincestari
Copy link
Member

This changes the access modifier of the GraphQLField.cacheKey function from internal to public.

The caveat to this change is:

For the 1.0 release, I'd like to consider if there is a better way to expose cache keys that is safer and more stable, but since we are rewriting a large piece of the execution layer there, exposing this in the 0.x version for now seems fine.

Closes #1972

@calvincestari calvincestari added this to the Release 0.50.0 milestone Nov 2, 2021
calvincestari
calvincestari commented Nov 2, 2021
View reviewed changes
Tests/ApolloTests/CacheKeyForFieldTests.swift
@@ -1,5 +1,5 @@
import XCTest
@testable import Apollo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in two minds about this change. I left it in as a forcing function of-sorts for anyone who one day thinks public might be the wrong choice. I could easily be convinced to revert this line if someone feels strongly that it should remain @testable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, though we should probably do some audits of where we're using @testable import separate from this.

designatednerd
designatednerd approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved given the caveat.

@calvincestari calvincestari merged commit 9cab672 into main Nov 3, 2021
@calvincestari calvincestari deleted the issue/1972-making-graphqlfield-cachekey-public branch November 3, 2021 19:48
calvincestari added a commit that referenced this pull request Nov 19, 2021
@calvincestari
Squashed merge commit up to 3262cd0
675af6e 
Squashed commit of the following:

commit 3262cd0
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Nov 18 03:49:51 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.8 (#2038)

    Co-authored-by: Renovate Bot <[email protected]>

commit d93568f
Author: Calvin Cestari <[email protected]>
Date:   Wed Nov 17 12:51:58 2021 -0800

    Release `0.50.0` (#2031)

    * Update version number for release
    * Updated changelog for release
    * Update documentation for release changes
    * Update changelog for #2015

commit 46957a3
Author: Hesham Salman <[email protected]>
Date:   Wed Nov 17 15:15:54 2021 -0500

    Update SQLite.swift to version 13.0 (#2015)

    * Update Package.swift and podspec
    * Updated XcodeProj
    * Bump SQLite.swift minimum required version to 0.13.1

    Co-authored-by: Calvin Cestari <[email protected]>

commit 8d48031
Author: hwillson <[email protected]>
Date:   Fri Nov 12 16:24:18 2021 -0500

    Gateway clarification based on license change

commit 55c5db8
Author: Calvin Cestari <[email protected]>
Date:   Fri Nov 12 10:47:33 2021 -0800

    Update apollo-tooling to v2.33.9 (#2028)

    * Update to v2.33.9 of the CLI tooling
    * Update StarWarsAPI output generated by updated tooling
    * Update test with expected output
    * Keep the parameter spacing

commit ece5b5b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Nov 10 22:13:58 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.6 (#2026)

    Co-authored-by: Renovate Bot <[email protected]>

commit a8a35ae
Author: Anthony Miller <[email protected]>
Date:   Tue Nov 9 11:50:36 2021 -0800

    Attempted fix for integration test failing on CI (#2024)

commit a1e857c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Nov 8 16:24:21 2021 -0800

    Bump apollo-server from 2.16.1 to 2.25.3 in /SimpleUploadServer (#2020)

    Bumps [apollo-server](https://github.com/apollographql/apollo-server/tree/HEAD/packages/apollo-server) from 2.16.1 to 2.25.3.
    - [Release notes](https://github.com/apollographql/apollo-server/releases)
    - [Changelog](https://github.com/apollographql/apollo-server/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/apollographql/apollo-server/commits/[email protected]/packages/apollo-server)

    ---
    updated-dependencies:
    - dependency-name: apollo-server
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6bf4362
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Nov 9 00:03:55 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.2 (#2021)

    Co-authored-by: Renovate Bot <[email protected]>

commit 3bfde02
Author: Mike Pitre <[email protected]>
Date:   Mon Nov 8 13:58:36 2021 -0500

    GET method for `ApolloSchemaDownloader` (#2010)

    * GET method for ApolloSchemaDownloader
    * Minor improvements to HTTP method enum
    * Remove ApolloSchemaDownload scope from name
    * Add documentation
    * Add HTTP method string constants as output
    * Add error for unsupported HTTP method when using Apollo Registry
    * Move HTTP method support into DownloadMethod
    * Build requests based on DownloadMethod
    * Add tests for DownloadMethod HTTP method configurations
    * Clean up and clarify documentation
    * Add associated values to URL-related errors

    Co-authored-by: Calvin Cestari <[email protected]>

commit 9cab672
Author: Calvin Cestari <[email protected]>
Date:   Wed Nov 3 12:48:57 2021 -0700

    Expose `cacheKey` function as `public` (#2014)

    * Expose cacheKey function as public
    * Remove @testable attribute to require public access to cacheKey function

commit f2a4983
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Oct 28 01:40:10 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.1 (#2006)

    Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

@AnthonyMDev AnthonyMDev Awaiting requested review from AnthonyMDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.50.0
Development

Successfully merging this pull request may close these issues.

Making GraphQLField's cacheKey method public instead of internal
2 participants
@calvincestari @designatednerd