Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 5 and Xcode 10.2 support #482

Closed
wants to merge 5 commits into from
Closed

Swift 5 and Xcode 10.2 support #482

wants to merge 5 commits into from

Conversation

fassko
Copy link
Contributor

@fassko fassko commented Mar 26, 2019

No description provided.

@martijnwalraven
Copy link
Contributor

Thanks for the PR! But I'm hoping now that Xcode 10.2 is out we can land the more comprehensive #475.

@fassko
Copy link
Contributor Author

fassko commented Mar 26, 2019

@martijnwalraven Thanks. That PR #475 would be great. In this PR I updated Starscream. I released Swift 5 and Xcode 10.2 support for that library. Although there is still hanging #466

@martijnwalraven
Copy link
Contributor

What do you think we should do while we wait for #475? Any chance you can update #466 with the new Starscream version? Or would you prefer to close that one and merge this PR instead?

@fassko
Copy link
Contributor Author

fassko commented Mar 26, 2019

I will update #466 so it could be easier to merge after #475 I hope it will be soon merged. :)

@martijnwalraven
Copy link
Contributor

Closing this in favor of #475 and #466.

@fwal fwal mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fassko @martijnwalraven