Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed swift versions to 5 for ApolloSQLite #484

Closed
wants to merge 2 commits into from

Conversation

naknut
Copy link

@naknut naknut commented Mar 26, 2019

If you try to build the current master with Carthage using Xcode 10.2 you get the following error:

error: SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'ApolloSQLite')

This its because Swift 3 is unsupported from Xcode 10.2 and forward. Lowest supported version is 4.0. After this change we compile all the schemes using the Swift 5 compiler so Carthage won't fail any more.

@apollo-cla
Copy link

@naknut: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@naknut naknut changed the title Changed swift versions to 5 Changed swift versions to 5 for ApolloSQLite Mar 26, 2019
@jimisaacs
Copy link
Contributor

@naknut hopefully those test failures are not caused by the build change :/
Our team would love this change to get in.
Do you have any Carthage work arounds in the mean time?

@naknut
Copy link
Author

naknut commented Mar 26, 2019

@jimisaacs I think it’s related. It seems like Travis doesn’t have Swift 5 support yet. That’s why it fails. I guess you can point to my version your Cartfile in the meantime. You can find my updates and patches version here.

@jimisaacs
Copy link
Contributor

jimisaacs commented Mar 26, 2019

@naknut Great suggestion, I'll give that a shot as a workaround.

@jimisaacs
Copy link
Contributor

@naknut I think I'd prefer if the version could stay 4.2 for the time being. I'll fork myself if I can get my build working without requiring 10.2

@martijnwalraven
Copy link
Contributor

Closing this in favor of #475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants