Code

Result ALL THE THINGS!!!#644

Code

Merged

designatednerd merged 21 commits intomasterapollographql/apollo-ios:masterfrom change/result-type-returnsapollographql/apollo-ios:change/result-type-returnsCopy head branch name to clipboardJul 22, 2019

+880-532

Commits

Commits on Jul 22, 2019

• remove deprecated handler type

  designatednerd

  committed
  7b9c291

  Copy full SHA for 7b9c291

• Switch to Result type with the GraphQLResultHandler

  designatednerd

  committed
  52e1d8a

  Copy full SHA for 52e1d8a

• update ApolloTests and ApolloCacheDependentTests

  designatednerd

  committed
  586a55e

  Copy full SHA for 586a55e

• update SQLite tests for result type

  designatednerd

  committed
  339b1f9

  Copy full SHA for 339b1f9

• Fix placement of call to go out to network

  designatednerd

  committed
  f772a2a

  Copy full SHA for f772a2a

• Check for correct errors in tests

  designatednerd

  committed
  f485989

  Copy full SHA for f485989

• Update Websocket to use swift result for completion handlers

  designatednerd

  committed
  801efb9

  Copy full SHA for 801efb9

• fix typo in test class name

  designatednerd

  committed
  0bc5833

  Copy full SHA for 0bc5833

• Update web socket tests for result type

  designatednerd

  committed
  b42cc37

  Copy full SHA for b42cc37

• Update documentation

  designatednerd

  committed
  6ca1e8a

  Copy full SHA for 6ca1e8a

• move send into an extension to make it clearer that this method is conforming to the NetworkTransport protocol

  designatednerd

  committed
  4be1186

  Copy full SHA for 4be1186

• rm whitespace

  designatednerd

  committed
  94a0073

  Copy full SHA for 94a0073

• pull out split network transport's NetworkTransport conformance; update docs

  designatednerd

  committed
  0c059b4

  Copy full SHA for 0c059b4

• pull out WebSocketTransport's NetworkTransport and WebSocketDelegate into extensions.

  designatednerd

  committed
  647a7da

  Copy full SHA for 647a7da

• rm excess whitespace 🤦‍♀️

  designatednerd

  committed
  3725fe0

  Copy full SHA for 3725fe0

• Clarify header comment a bit

  designatednerd

  committed
  acf11ee

  Copy full SHA for acf11ee

• rm excess whitespace

  designatednerd

  committed
  f9bafbf

  Copy full SHA for f9bafbf

• simplify check

  designatednerd

  committed
  6eac173

  Copy full SHA for 6eac173

• clarify that GraphQLResult has both data and errors

  Show description for b29b681
  designatednerd

  committed
  b29b681

  Copy full SHA for b29b681

• outerResult -> result anywhere there isn't actually an inner result.

  designatednerd

  committed
  8c4cbde

  Copy full SHA for 8c4cbde

• rm whitespace

  designatednerd

  committed
  c8b94d8

  Copy full SHA for c8b94d8