Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

apollographql / apollo-ios Public

Notifications You must be signed in to change notification settings
Fork 738
Star 3.9k

Code
Issues 129
Pull requests
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Added correct way of default parameters#804

Merged

designatednerd merged 9 commits intoapollographql:masterapollographql/apollo-ios:masterfrom kimdv:kimdv/change-default-parameter-in-request-creatorkimdv/apollo-ios:kimdv/change-default-parameter-in-request-creatorCopy head branch name to clipboard

Oct 3, 2019

+146-18

Conversation Commits9 (9)Checks Files changed

Commits

Commits on Oct 2, 2019

Added correct way of default parameters
kimdv
committed
Remove default parameter
kimdv
committed
Remove default parameters
kimdv
committed
Renamed to RequestCreatorTests to match what it is doing. Added request creator tests.
kimdv
committed
Move TestRequestCreator -> TestCustomRequestCreator
kimdv
committed

Commits on Oct 3, 2019

Removed fileprivate and made import testable
kimdv
committed
Made method public as it was missing
kimdv
committed
Fixed tests
kimdv
committed
Made tests pass. Becaue TestCustomrequestCreator uses a dictionary we cannot rely on the order
kimdv
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.