fix(compiler): InputValueDefinition::is_required() returns false if there is a default value #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there is a default value
SimonSapin
approved these changes
Jan 8, 2024
|
I didn't find any! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
argument.is_required() == trueonly if the type is non-null and there is nodefault value, meaning a value must be provided when it's used. This is how the
spec describes required arguments.
This seems more useful as the previous implementation can already be achieved
by checking
argument.ty.is_non_null().It's kind of a fix, kind of just a change, kind of breaking...