Skip to content

Commit

Permalink
Update dependencies accept & boom to new namespace (#3089)
Browse files Browse the repository at this point in the history
* Update dependencies accept & boom to new namespace

Update dependencies module names and to latest version (no breaking changes)
Avoid npm warning:
[email protected]: This module has moved and is now available at @hapi/accept
[email protected]: This module has moved and is now available at @hapi/boom

* Add CHANGELOG.md for #3089.
  • Loading branch information
taina0407 authored and abernix committed Jul 28, 2019
1 parent bf7051e commit 0de2942
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The version headers in this history reflect the versions of Apollo Server itself
- `@apollo/federation`: Add support for "value types", which are type definitions which live on multiple services' types, inputs, unions or interfaces. These common types must be identical by name, kind and field across all services. [PR #3063](https://github.com/apollographql/apollo-server/pull/3063)
- `apollo-server-express`: Use the Express `send` method, rather than calling `net.Socket.prototype.end`. [PR #2842](https://github.com/apollographql/apollo-server/pull/2842)
- `apollo-server-hapi`: Update internal dependencies to use scoped packages `@hapi/accept` and `@hapi/boom`, in place of `accept` and `boom` respectively. [PR #3089](https://github.com/apollographql/apollo-server/pull/3089)

### v2.7.2

Expand Down
4 changes: 2 additions & 2 deletions packages/apollo-server-hapi/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.24",
"accept": "^3.0.2",
"@hapi/accept": "^3.2.2",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-types": "file:../apollo-server-types",
"boom": "^7.1.0",
"@hapi/boom": "^7.4.2",
"graphql-subscriptions": "^1.0.0",
"graphql-tools": "^4.0.0"
},
Expand Down

2 comments on commit 0de2942

@ricardovanh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taina0407 @abernix shouldn't the namespace also be added to the ApolloServer.ts file's imports? I just made a fresh install and the server is breaking when I create the Apollo server.

import { parseAll } from 'accept';

@taina0407
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazyricardo Sorry for my stupid bug! already pull a new PR at (#3106) for fixing this.

Please sign in to comment.