Skip to content

Commit

Permalink
Remove now-unnecessary guard which checks for errors.
Browse files Browse the repository at this point in the history
This is no longer necessary after the changes in @jbaxleyiii's
#2574 (and
@martijnwalraven's
#2416), which changed the
error reporting to be captured via the newly introduced
`didEncounterErrors`, rather than in `willResolveField` where it used to
happen.  Yay!
  • Loading branch information
abernix committed Apr 26, 2019
1 parent e2279ee commit 7ffd5e2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions packages/apollo-engine-reporting/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,6 @@ export class EngineReportingExtension<TContext = any>
}

public didEncounterErrors(errors: GraphQLError[]) {
// This life-cycle method is only invoked to capture errors.
if (!errors) {
return;
}

errors.forEach(err => {
// In terms of reporting, errors can be re-written by the user by
// utilizing the `rewriteError` parameter. This allows changing
Expand Down

0 comments on commit 7ffd5e2

Please sign in to comment.