-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AS3: Consider documenting migration to graphql-ws in addition to how to preserve subscriptions-transport-ws #4960
Comments
We are not going to document We're hoping to bring subscription support to the Apollo platform in a more holistic and supported way sometime in the medium term future. Most likely we will choose the newer protocol/implementation when we do so, and we will at least link to it in the subscriptions docs, but for the moment it's not helpful to provide detailed docs on how to integrate with something when we're not also providing client-side support for the same library. |
Would like to point out that, due to the distinct subprotocol names, both GraphQL over WebSocket protocols can be supported in parallel. For the server, you may consult the "ws server usage with subscriptions-transport-ws backwards compatibility" recipe to understand how. And for the client, you simply can do a test-try connect to a server and check if the socket got closed with a 1002. Very similar to the GraphQL Playground |
Fixed in #5406. |
@enisdenjo Agreed! Right now we're in the final moments of putting an AS3 release out, and so backing up and making sure that various clients support the new protocol so we could document the new package as the recommended approach didn't make sense. That doesn't mean we don't want to support/encourage it and once more of the IDEs support it, we can revisit this. |
Oops, forgot to include text about graphql-ws in the subscriptions page and not just the migration page. #5410 |
We should document how to migrate from "AS2 plus built-in subscriptions-transport-ws" to "AS3 plus your own subscriptions-transport-ws" for ease of upgrade, but we should evaluate if graphql-ws is a better solution for new users wanting to add subscriptions (without full Apollo Server integration, but that's not available with subscriptions-transport-ws either).
The text was updated successfully, but these errors were encountered: