Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache control: defaultMaxAge shouldn't be applied if you use dynamic cache control #5488

Closed
glasser opened this issue Jul 15, 2021 · 1 comment · Fixed by #5492
Closed

cache control: defaultMaxAge shouldn't be applied if you use dynamic cache control #5488

glasser opened this issue Jul 15, 2021 · 1 comment · Fixed by #5492

Comments

@glasser
Copy link
Member

glasser commented Jul 15, 2021

Specifically, you should be able to call info.cacheControl.cacheHint.restrict on a top-level field and have it do what you want. This is part of the new cache control logic in AS3 but is a bug that we should fix ASAP. See apollographql/federation#870
@glasser glasser added this to the MM-2021-07 milestone Jul 15, 2021
@glasser glasser mentioned this issue Jul 15, 2021
Merged
glasser added a commit that referenced this issue Jul 16, 2021
@glasser
cache control: don't apply default max age until after resolver runs
38a6221 
This also gives resolvers the ability to differentiate between a
`maxAge` that was explicitly set but happens to equal the default
`maxAge` and one that was not explicitly set.

Fixes #5488. Helpful for apollo/federation#870.
@glasser glasser mentioned this issue Jul 16, 2021
Merged
glasser added a commit that referenced this issue Jul 16, 2021
@glasser
cache control: don't apply default max age until after resolver runs
f1c1732 
This also gives resolvers the ability to differentiate between a
`maxAge` that was explicitly set but happens to equal the default
`maxAge` and one that was not explicitly set.

Fixes #5488. Helpful for apollo/federation#870.
glasser added a commit that referenced this issue Jul 16, 2021
@glasser
cache control: don't apply default max age until after resolver runs (#…
70f5515 
…5492)

This also gives resolvers the ability to differentiate between a
`maxAge` that was explicitly set but happens to equal the default
`maxAge` and one that was not explicitly set.

Fixes #5488. Helpful for apollo/federation#870.
@glasser
Copy link
Member Author

glasser commented Jul 16, 2021

Fix released in 3.0.1.

@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cache control: don't apply default max age until after resolver runs apollographql/apollo-server
2 participants
@glasser @hwillson