Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-hapi: replace deprecated hapi by @hapi/hapi #3217

Closed
wants to merge 1 commit into from

Conversation

mblottiere
Copy link

This aims to fix #3132

@abernix
Copy link
Member

abernix commented Aug 27, 2019

This attempts the same/similar update as #3089 which we reverted in #3111. Unfortunately, because of the dropping of Node.js 6 support, we'll have to reject it for the same reasons noted in #3111.

Without bumping the major version of Apollo Server to 3.x, there's no semver-correct way to release this under the 2.x umbrella. I realize this is problematic, but this is exactly the reason that we are introducing the concept of transports (see #3184) that can be versioned separately and live outside of Apollo Server core.

@abernix abernix closed this Aug 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in typescript definitions using hapi server
2 participants