gateway: Small improvements to error messages and behavior during updates.#3811

Merged

abernix merged 29 commits intorelease-2.12.0from abernix/gateway-minor-qol-improvements

Mar 6, 2020

+396-169

Commits on Mar 3, 2020

Adjust deceiving error message about previous schemas and falling back.

abernix
authored and
trevor-scheer
committed
Throw when updating the schema doesn't fail as expected.

abernix
authored and
trevor-scheer
committed
Adjust error message wording to be more concise.

abernix
authored and
trevor-scheer
committed
Move "previous" variables closer to where they are used.

abernix
authored and
trevor-scheer
committed
Align error messages with consistent terminology and add clarity.

abernix
authored and
trevor-scheer
committed
logging: Raise severity from warn to error for what is certainly an error.

abernix
authored and
trevor-scheer
committed
Switch to using single argument logger usage and serialization.

abernix
authored and
trevor-scheer
committed
gateway: Trap unhandled promise rejections in polling.

abernix
authored and
trevor-scheer
committed
Remove incorrect comment about typings being an appropriate assertion.

abernix
authored and
trevor-scheer
committed
typings: Remove any type!

abernix
authored and
trevor-scheer
committed
Use the same fetch response handling for the waterfall of GCS requests.

abernix
authored and
trevor-scheer
committed
Do not prefix potentially the same error object on every request.

abernix
authored and
trevor-scheer
committed
Ensure the executor is set in gateway mode after failed load recoveries.

abernix
authored and
trevor-scheer
committed
Ensure that initial gateway load failures trap the downstream error.

abernix
authored and
trevor-scheer
committed
Allow other middleware (e.g. Playground) when initial Gateway load fails.

abernix
authored and
trevor-scheer
committed
Ensure the executor is still set on ApolloServer when load rejects.

abernix
authored and
trevor-scheer
committed
Expect the expected errors, rather than swallowing them.

abernix
authored and
trevor-scheer
committed
Update packages/apollo-gateway/src/__tests__/gateway/executor.test.ts

abernix
and
trevor-scheer
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gateway: Small improvements to error messages and behavior during updates.#3811

Commits on Mar 3, 2020

Adjust deceiving error message about previous schemas and falling back.

Throw when updating the schema doesn't fail as expected.

Adjust error message wording to be more concise.

Move "previous" variables closer to where they are used.

Align error messages with consistent terminology and add clarity.

logging: Raise severity from `warn` to `error` for what is certainly an error.

Switch to using single argument logger usage and serialization.

gateway: Trap unhandled promise rejections in polling.

Remove incorrect comment about typings being an appropriate assertion.

typings: Remove `any` type!

Use the same fetch response handling for the waterfall of GCS requests.

Do not prefix potentially the same error object on every request.

Ensure the `executor` is set in gateway mode after failed `load` recoveries.

Ensure that initial gateway `load` failures trap the downstream error.

Allow other middleware (e.g. Playground) when initial Gateway load fails.

Ensure the `executor` is still set on `ApolloServer` when `load` rejects.

Expect the expected errors, rather than swallowing them.

Update packages/apollo-gateway/src/tests/gateway/executor.test.ts

Commits on Mar 4, 2020

Update packages/apollo-gateway/src/loadServicesFromStorage.ts

Revert "Update packages/apollo-gateway/src/loadServicesFromStorage.ts"

Re-apply `4d4ab5b`: apollo-gateway/src/loadServicesFromStorage.ts

Commits on Mar 6, 2020

chore(deps): update dependency gatsby-theme-apollo-docs to v4.0.13 (#3856 )

Add comment to preserve concern about typings from @trevor-scheer .

Change error message to not include word "lacks".

Add more helpful error message and docs link to `fetchApolloGcs`.

Remove CHANGELOG.md annotations for pre-release version designators.

Merge remote-tracking branch 'origin/master' into release-2.12.0

Merge branch 'release-2.12.0' into abernix/gateway-minor-qol-improvements

Add CHANGELOG.md for #3811 .