schema-reporting: Check whether overrideReportedSchema is parsable/valid #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
changed the title
sachindshinde
force-pushed
the
sachin/parse-and-validate-override-schema-in-schema-reporting
branch
from
b2f6560 to
5a60140
Compare
jsegaran
approved these changes
Aug 31, 2020
sachindshinde
force-pushed
the
sachin/parse-and-validate-override-schema-in-schema-reporting
branch
from
5a60140 to
4100986
Compare
…eReportedSchema parses/validates
sachindshinde
force-pushed
the
sachin/parse-and-validate-override-schema-in-schema-reporting
branch
from
61ad418 to
9061ed1
Compare
zionts
deleted the
sachin/parse-and-validate-override-schema-in-schema-reporting
branch
trevor-scheer
added
📡 schema-reporting
🧮 usage-reporting
⛲️ feature
|
@sachindshinde would you please add tests to cover this new option when you get the chance? If you can't (that's ok!) please open an issue that references this PR. Thank you 😄 |
|
@trevor-scheer I talked to David, when his large PR for |
glasser
added a commit
that referenced
this pull request
Sep 18, 2020
The Apollo API has recently changed such that `reportServerInfo` will now return error for schemas that don't parse or validate. This PR changes `apollo-engine-reporting` to check in the `EngineReportingAgent` constructor whether override schemas successfully parse and validate, so that we may return early before talking to the Apollo API. (Originally #4492 by @sachindshinde, merged directly into release-2.18.0; because the main change being released with v2.18 is #4453 which entirely replaced the file which that PR changed, this is being reconstructed as part of PR #4453.)
|
Incorporated this change into #4453. I did not add the tests though; @sachindshinde, can you do so? (#4453 should merge into release-2.18.0 shortly.) |
Merged
glasser
added a commit
that referenced
this pull request
Sep 18, 2020
The Apollo API has recently changed such that `reportServerInfo` will now return error for schemas that don't parse or validate. This PR changes `apollo-engine-reporting` to check in the `EngineReportingAgent` constructor whether override schemas successfully parse and validate, so that we may return early before talking to the Apollo API. (Originally #4492 by @sachindshinde, merged directly into release-2.18.0; because the main change being released with v2.18 is #4453 which entirely replaced the file which that PR changed, this is being reconstructed as part of PR #4453.)
|
@glasser Yep, I can add tests in a new PR 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apollo API has recently changed such that
reportServerInfowill now return error for schemas that don't parse or validate.This PR changes
apollo-engine-reportingto check in theEngineReportingAgentconstructor whether override schemas successfully parse and validate, so that we may return early before talking to the Apollo API.