Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates error when schema reporting is used with federation #4567

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

EverlastingBugstopper
Copy link
Contributor

it's helpful to have an actionable message when something goes wrong
aside from a simple "contact support" if there is a way to achieve
the action that caused the error. in this case, the user is likely
trying to set up Apollo Studio with their service, which they can do
if they follow along with the documentation. this change adds a link
to said documentation to immediately unblock users who run into this
error.

it's helpful to have an actionable message when something goes wrong
aside from a simple "contact support" if there is a way to achieve
the action that caused the error. in this case, the user is likely
trying to set up Apollo Studio with their service, which they can do
if they follow along with the documentation. this change adds a link
to said documentation to immediately unblock users who run into this
error.
@EverlastingBugstopper EverlastingBugstopper added 🧞‍♂️ enhancement 👩‍🚀 federation 🍐 error-handling Pertaining to error handling (or lack thereof), not just for just general errors/bugs. labels Sep 16, 2020
@glasser
Copy link
Member

glasser commented Sep 16, 2020

Thanks!

@glasser glasser merged commit cb77929 into glasser/apollo-config Sep 16, 2020
@abernix
Copy link
Member

abernix commented Sep 18, 2020

I can adjust this, but we have /s/-scoped (🐍 is for Server) short links that we try to assign for any links in error messages so we can:

  1. Know what shortlinks are still used in our code so we can remember to track them down if we want to change them.
  2. Keep the error messages shorter!

@abernix abernix deleted the avery/update-federation-error branch September 18, 2020 13:20
@EverlastingBugstopper
Copy link
Contributor Author

fixed it up in #4570 and https://github.com/apollographql/shortlinks/pull/8 :)

glasser pushed a commit that referenced this pull request Sep 18, 2020
it's helpful to have an actionable message when something goes wrong
aside from a simple "contact support" if there is a way to achieve
the action that caused the error. in this case, the user is likely
trying to set up Apollo Studio with their service, which they can do
if they follow along with the documentation. this change adds a link
to said documentation to immediately unblock users who run into this
error.
glasser pushed a commit that referenced this pull request Sep 18, 2020
it's helpful to have an actionable message when something goes wrong
aside from a simple "contact support" if there is a way to achieve
the action that caused the error. in this case, the user is likely
trying to set up Apollo Studio with their service, which they can do
if they follow along with the documentation. this change adds a link
to said documentation to immediately unblock users who run into this
error.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧞‍♂️ enhancement 🍐 error-handling Pertaining to error handling (or lack thereof), not just for just general errors/bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants