Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default query case when query value null is provider #512

Merged
merged 2 commits into from
Aug 24, 2017

Conversation

nikgraf
Copy link
Contributor

@nikgraf nikgraf commented Aug 19, 2017

I noticed when using in production the query will not be undefined, but null. This doesn't work with default arguments.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo
Copy link
Contributor

Thanks!

@stubailo stubailo merged commit 462fb43 into apollographql:master Aug 24, 2017
@nikgraf nikgraf deleted the patch-2 branch August 24, 2017 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants