Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test on Node 16, switch to newer cimg images #5137

Merged
merged 1 commit into from
May 3, 2021
Merged

CI: test on Node 16, switch to newer cimg images #5137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
# at https://hub.docker.com/r/circleci/node/.

NodeJS 12:
executor: { name: oss/node, tag: '12' }
docker:
- image: cimg/node:12.22.1
steps:
- common_test_steps
# We will save the results of this one particular invocation to use in
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on if we should bump this to the 14 or 16 job?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had written out a longer comment but somehow lost it. Let's wait and ticket this for follow-up in a few weeks? (Feel free to assign to me). Basically, this persist_to_workspace thing propagates things to the Tarballs and Publishing steps: https://github.com/apollographql/CircleCI-Orbs/blob/main/src/oss-ci-cd-tooling/orb.yml#L319-L346

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still curious about this fwiw, but merging @abernix

Expand All @@ -52,7 +53,14 @@ jobs:
- ./**

NodeJS 14:
executor: { name: oss/node, tag: '14' }
docker:
- image: cimg/node:14.16.1
steps:
- common_test_steps

NodeJS 16:
docker:
- image: cimg/node:16.0.0
steps:
- common_test_steps

Expand Down Expand Up @@ -104,19 +112,23 @@ workflows:
<<: *common_non_publish_filters
- NodeJS 14:
<<: *common_non_publish_filters
- NodeJS 16:
<<: *common_non_publish_filters
- "Check for FIXM\x45"
- oss/lerna_tarballs:
name: Package tarballs
<<: *common_non_publish_filters
requires:
- NodeJS 12
- NodeJS 14
- NodeJS 16
- oss/dry_run:
name: Dry-run
<<: *common_publish_filters
requires:
- NodeJS 12
- NodeJS 14
- NodeJS 16
- oss/confirmation:
name: Confirmation
type: approval
Expand Down
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"engines": {
"node": ">=14 <15",
"node": ">=16 <17",
"npm": "6.x"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"coverage:upload": "codecov"
},
"engines": {
"node": ">=14.0 <15.0",
"node": ">=12",
"npm": "^6.14.11"
},
"dependencies": {
Expand Down