apollo-reporting-protobuf: check in generated code, regenerate manually #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, the `marked` project pushed a minor release that broke Node 12 compatibility: markedjs/marked#2106 `marked` is a dep of `jsdoc` which is a dep of the protobufjs CLI. Unfortunately it turns out that the protobufjs CLI installs dependencies including `jsdoc` *at runtime*, *unversioned*. Yikes! See `setup` https://github.com/apollographql/protobuf.js/blob/master/cli/util.js I tried changing our fork to not do this and move the deps to be dev deps of this project (see `@apollo/[email protected]`) but that didn't work out on the first try. So instead, let's just not require the protobufjs CLI to work on Node 12, and also start saving time by not constantly regenerating the code in this package. Now code is only generated manually (`lerna run generate`) and checked in, and it can be done on the latest Node.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the
markedproject pushed a minor release that broke Node 12compatibility: markedjs/marked#2106
markedis a dep ofjsdocwhich is a dep of the protobufjs CLI.Unfortunately it turns out that the protobufjs CLI installs dependencies
including
jsdocat runtime, unversioned. Yikes! Seesetuphttps://github.com/apollographql/protobuf.js/blob/master/cli/util.js
I tried changing our fork to not do this and move the deps to be dev
deps of this project (see
@apollo/[email protected]) but that didn'twork out on the first try. So instead, let's just not require the
protobufjs CLI to work on Node 12, and also start saving time by not
constantly regenerating the code in this package. Now code is only
generated manually (
lerna run generate) and checked in, and it can bedone on the latest Node.