Gateway now supported #6801
Merged
Gateway now supported #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73d0fc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73d0fc0:
|
glasser
force-pushed
the
glasser/gateway-supported
branch
2 times, most recently
from
d0811d2 to
beb9261
Compare
- Add tests that passing ApolloGateway to ApolloServer typechecks with a variety of packages. (Will probably need to mess around with Renovate to not have it mess this up.) - Update docs to say that gateway works with any version that supports graphql@16. Note that the graphql@16 peer dep was added to gateway with v0.47.0 (2022-Feb-03), but until v0.50.1 (2022-Apr-13) it had a dependency on `apollo-utilities` whose peer dep didn't allow v16. It's possible that releases during that two month span worked with v16 in practice (forcing the peer dep) but it seems best to only recommend versions that don't require forcing peer deps (and there aren't any documented breaking changes between these two versions other than requiring newer `graphql`). The most explicit requirement is that we need v0.35.0 because we assume gateway has onSchemaLoadOrUpdate. Testing this requires disabling npm engine-strict on Node 18.
glasser
force-pushed
the
glasser/gateway-supported
branch
from
beb9261 to
73d0fc0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variety of packages. (Will probably need to mess around with Renovate to
not have it mess this up.)
graphql@16.
Note that the graphql@16 peer dep was added to gateway with v0.47.0
(2022-Feb-03), but until v0.50.1 (2022-Apr-13) it had a dependency on
apollo-utilitieswhose peer dep didn't allow v16. It's possible thatreleases during that two month span worked with v16 in practice (forcing
the peer dep) but it seems best to only recommend versions that don't
require forcing peer deps (and there aren't any documented breaking
changes between these two versions other than requiring newer
graphql). The most explicit requirement is that we need v0.35.0because we assume gateway has onSchemaLoadOrUpdate.
Fixes #6719.