Fix error locations for .graphql files and tagged strings with leading newlines #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this plugin! I ran into some odd error locations when using it with raw
.graphql
files, and it looks like the ultimate culprit was an off-by-one bug 🙂If this was a change that affects the external API, update the READMEPrior to this change, the contents of tagged strings were having leading and trailing whitespace trimmed before being processed. This masked an off-by-one error in the location calculation for errors after the first line of a document, since the most common usage pattern has a single extra leading line before the actual content which offsets that:
This meant that standalone
.graphql
files had all their errors displayed on the wrong line (unless they opened with a single blank line as well), and tagged strings with multiple newlines at their start would also have issues. This patch removes the.trim()
call and updates theline
/column
calculations to report the correct location.