Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-port update from #2037 (backport of #2039) #2040

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented Aug 4, 2022

Turns out that if you have AS3 in your TS build (which version-0.x
does), you need to be a bit more careful how you declare some things.
This commit ensures that the extra care required for version-0.x doesn't
break main.

Turns out that if you have AS3 in your TS build (which version-0.x
does), you need to be a bit more careful how you declare some things.
This commit ensures that the extra care required for version-0.x doesn't
break main.
@glasser glasser requested a review from benweatherman August 4, 2022 20:50
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 7edd265
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/62ec311156903e00082f3ae4

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@glasser glasser merged commit 54ff893 into main Aug 4, 2022
@glasser glasser deleted the glasser/forward-port-fix-from-backport-of-2037 branch August 4, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants