Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vestigial connector preview errors #3170

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

lennyburdette
Copy link
Contributor

these errors are technically in fed 2.7 but were removed for 2.9 and beyond. we never formally documented the directives that would trigger them so they can be removed.

this file isn't generated is it?

these errors are technically in fed 2.7 but were removed for 2.9 and beyond. we never formally documented the directives that would trigger them so they can be removed.

this file isn't generated is it?
@lennyburdette lennyburdette requested a review from a team as a code owner October 17, 2024 14:46
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 3ac4bc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 17, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/federation@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "federation",
        "branch": "lb/source-errors"
      }
    }
  }
}
Name Link

Commit

3ac4bc5

Preview

https://www.apollographql.com/docs/deploy-preview/7ebf9817294b30c574a4

Build ID

7ebf9817294b30c574a4

File Changes

0 new, 1 changed, 0 removed
* graphos/reference/federation/errors.mdx

Pages

1


1 pages published. Build will be available for 30 days.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit 3ac4bc5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/67112348c60721000842b4c5
😎 Deploy Preview https://deploy-preview-3170--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

The file isn't autogenerated afaik.

@lennyburdette lennyburdette merged commit 3675afe into main Oct 17, 2024
17 of 18 checks passed
@lennyburdette lennyburdette deleted the lb/source-errors branch October 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants