-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fed versions #3171
docs: fed versions #3171
Conversation
✅ Docs Preview ReadyConfiguration{
"repoOverrides": {
"apollographql/federation@main": {
"remote": {
"owner": "apollographql",
"repo": "federation",
"branch": "eh/docs/fed-version-spacing"
}
}
}
}
2 pages published. Build will be available for 30 days. |
|
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to add spacing but keep things horizontal? (I feel like using an extra line break might not be necessary?)
I think this has been vertical all along? (Can't prove it with both old docs and wayback machine down ...) |
I mean the |
ah, I meant that having the I prefer them on separate lines, easier to scan |
Got it. I have a preference for the horizontal version since it seems more natural/space-efficient for me, but I'm fine with whatever you decide! |
Fix spacing and line breaks for Fed versions page