This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Align to React version 16.8.3, fix build issues #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of React Native (0.59). Fix build issues on Windows by using 'npx' instead of direct execution. Eliminate dependency warning by using new namespace react testing library.
|
@matthargett: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
hwillson
suggested changes
Jun 6, 2019
There was a problem hiding this comment.
Great stuff @matthargett, thanks very much! Just one small suggested change (and a question for @benjamn regarding the npx switch back), then we can get this merged.
loosen React requirement Co-Authored-By: Hugh Willson <[email protected]>
|
@hwillson ping? Anything else I need to do for this to be merged? |
|
Thanks again for this @matthargett and don't worry about having to keep this up to date with recent changes. We've been adjusting the way we handle tests, which I know is annoying to have to rebase against. I'll get this in synch with the other changes shortly, and get it merged in. |
Using `npx` within our child packages (and clearing `node_modules` between builds), means that `npx` first re-installs the script it's trying to call, since `npx` won't look in the monorepo parent `node_modules` directory. Needless to say this slows things like testing down. This commit adds the packages we reference via `npx` as dev dependencies in each child package. Yes, we're duplicating a few devDeps, but this way `npx` can find what it's looking for immediately. Renovate will help us keep the child package devDeps up to date, and using `npx` is a better cross platform way of handling scripts (than say using relative file references).
hwillson
approved these changes
Jun 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: