chore: re-use reqwest::Client instead of constructing one per request
#3333
Assignees
Comments
BrynCooke
pushed a commit
that referenced
this issue
Aug 29, 2023
6 tasks
BrynCooke
pushed a commit
that referenced
this issue
Aug 29, 2023
BrynCooke
added a commit
that referenced
this issue
Aug 29, 2023
Previously uplink requests created a new reqwest client each time, this may cause CPU spikes especially on OSX. Fixes #3333 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test` Co-authored-by: bryn <[email protected]>
Merged
Merged
garypen
pushed a commit
that referenced
this issue
Sep 12, 2023
Previously uplink requests created a new reqwest client each time, this may cause CPU spikes especially on OSX. Fixes #3333 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test` Co-authored-by: bryn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the code that handles sending requests to uplink creates a new
reqwest::Clienton each request.Reasoning from the
reqwestdocs on why you should re-use a client instead of building a new one:I propose making this client a
Lazy<reqwest::Client>and using that instead.The text was updated successfully, but these errors were encountered: