Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded schema parsing steps #3547

Merged
merged 3 commits into from
Aug 29, 2023
Merged

remove unneeded schema parsing steps #3547

merged 3 commits into from
Aug 29, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Aug 7, 2023

We do not need to parse the schema before license enforcement because it does not use it.
We do not need it either in orbiter because the factory contains the parsed schema

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Verified

This commit was signed with the committer’s verified signature.
FrankHassanabad Frank Hassanabad
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 7, 2023

CI performance tests

  • xxlarge-request - Stress test with 100 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity

Verified

This commit was signed with the committer’s verified signature.
FrankHassanabad Frank Hassanabad
@Geal Geal marked this pull request as ready for review August 9, 2023 08:17
@Geal Geal requested review from a team, garypen, SimonSapin and BrynCooke August 9, 2023 08:18
@abernix
Copy link
Member

abernix commented Aug 17, 2023

We do not need to parse the schema before license enforcement because it does not use it.

I think it was an intentional architectural decision to still do this even if we don't yet need it? @BrynCooke can you take a look at this?

@Geal
Copy link
Contributor Author

Geal commented Aug 24, 2023

it's not part of the public API, so we can reintroduce it when we need it. For now, this is just wasting CPU time when loading a new schema

@Geal
Copy link
Contributor Author

Geal commented Aug 29, 2023

@BrynCooke I'm merging this right now, feel free to reintroduce the schema in the licensing code when it's needed

@Geal Geal merged commit bbf3999 into dev Aug 29, 2023
@Geal Geal deleted the geal/unneeded-schema-parsing branch August 29, 2023 10:20
@Geal Geal mentioned this pull request Sep 4, 2023
@abernix abernix mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants