Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL response processing must happen under the execution span #3732

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Sep 4, 2023

Previously, any event in processing would be reported under the supergraph span, or any plugin span (like rhai) happening in between

Description here

Fixes #issue_number

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Sep 4, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@Geal Geal requested review from a team, SimonSapin, BrynCooke and bnjjj September 4, 2023 12:10
@Geal Geal changed the base branch from dev to 1.29.0 September 4, 2023 12:11
@Geal Geal changed the base branch from 1.29.0 to dev September 4, 2023 12:11
Geal added 2 commits September 4, 2023 14:12
Previously, any event in processing would be reported under the
supergraph span, or any plugin span (like rhai) happening in between
@Geal Geal force-pushed the geal/fix-execution-span-attribution branch from 36236e1 to a96acdb Compare September 4, 2023 12:13
@Geal Geal requested a review from a team as a code owner September 4, 2023 12:13
@Geal Geal changed the base branch from dev to 1.29.0 September 4, 2023 12:13
@Geal Geal enabled auto-merge (squash) September 4, 2023 12:20
@Geal Geal merged commit 73da94c into 1.29.0 Sep 4, 2023
@Geal Geal deleted the geal/fix-execution-span-attribution branch September 4, 2023 12:37
@Geal Geal mentioned this pull request Sep 4, 2023
@abernix abernix mentioned this pull request Sep 4, 2023
garypen pushed a commit that referenced this pull request Sep 12, 2023
Previously, any event in processing would be reported under the
supergraph span, or any plugin span (like rhai) happening in between
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants