feat: build for ARM unix devices #1137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-cli-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 3 commits
May 31, 2022 11:24
o0Ignition0o
approved these changes
Jun 8, 2022
|
There's quite a bit to review, I hope I didn't miss anything 😅 |
|
I've been updating the PR body here but wanted to provide another comment update - the next federation packages of v1/v2 could be a bit of a wait to get out the door. We're blocked here until those come out. |
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
|
What's the status of this PR? |
|
@EverlastingBugstopper It seems like supergraph was released with arm support a while ago. Is there anything still missing in order to merge this? |
19 tasks
|
closing in favor of #1356 - i've updated the status there, hoping to get this out soon. ARM support has landed in all plugin upstreams, |
EverlastingBugstopper
added a commit
that referenced
this pull request
Nov 10, 2022
This PR supercedes #1137 as the rebase was much too gnarly. This is essentially that same PR. Copying the description w/updated status below: We should not merge this PR and release ARM support until we can run the latest `rover supergraph compose` and `rover dev` commands on ARM. The following must happen, in order, before landing this PR. - [x] Test ARM support with `federation-rs` release candidates - [x] Release[`[email protected]` _(javascript)_](https://github.com/apollographql/federation) - [x] Release[`[email protected]` _(rust)_](https://github.com/apollographql/federation-rs) - [x] Test downloading and running `supergraph compose` with `2.0.6-rc.0` in a `supergraph.yaml` with `rover` built from `main` natively on an M1, and in Docker on an M1 - [x] Continue releasing release candidates until it all works. ~Hopefully it is just `2.0.6-rc.0`. If that works, it is safe to assume 0.x will work, so no release candidate will be needed there.~ _update: it was not that easy, the next two steps are new_ - [x] Remove the CI builds for `aarch64-apple-darwin` apollographql/federation-rs because [V8 snapshots cannot be cross-compiled from x86_64 machines](denoland/deno#4862 (comment)) and [CircleCI does not currently provide native ARM64 Mac machines](https://circleci.com/docs/2.0/using-arm/#m1-mac-support) meaning we _have_ to cross-compile if we want ARM binaries at all. If either of those things change, we will revisit this decision. - [x] Test downloading and running `supergraph compose` with `2.0.6-rc.1` in a `supergraph.yaml` with `rover` built from `main` natively on an arm ubuntu device, and in Docker on an M1 - [x] Release first stable `federation-rs` releases with native ARM support (only Linux binaries, no ARM64 MacOS binaries) - [x] Release [`[email protected]` _(javascript)_](https://github.com/apollographql/federation) - [x] Release [`[email protected]` _(rust)_](https://github.com/apollographql/federation-rs) - [x] Release [`[email protected]` _(javascript)_](https://github.com/apollographql/federation) - [x] Release [`[email protected]` _(rust)_](https://github.com/apollographql/federation-rs) - [x] Test downloading and running `supergraph compose` with the packages we just released - [x] Release [`[email protected]`](https://github.com/apollographql/router) - [x] Prepare ARM support for Rover - [x] Cut `[email protected]` - [x] Test downloading and running `supergraph compose` natively on an M1, and in Docker on an M1 - [x] Release more rcs until we are confident everything works - [x] Wait for the cloud router to default to version 2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not merge this PR and release ARM support until we can run the latest
rover supergraph composecommands on ARM.The following must happen in order before landing this PR.
federation-rsrelease candidates[email protected](javascript)[email protected](rust)supergraph composewith2.0.6-rc.0in asupergraph.yamlwithroverbuilt frommainnatively on an M1, and in Docker on an M1Hopefully it is justupdate: it was not that easy, the next two steps are new2.0.6-rc.0. If that works, it is safe to assume 0.x will work, so no release candidate will be needed there.aarch64-apple-darwinapollographql/federation-rs because V8 snapshots cannot be cross-compiled from x86_64 machines and CircleCI does not currently provide native ARM64 Mac machines meaning we have to cross-compile if we want ARM binaries at all. If either of those things change, we will revisit this decision.supergraph composewith2.0.6-rc.1in asupergraph.yamlwithroverbuilt frommainnatively on an arm ubuntu device, and in Docker on an M1federation-rsreleases with native ARM support (only Linux binaries, no ARM64 MacOS binaries)[email protected](javascript)[email protected](rust)[email protected](javascript)[email protected](rust)supergraph composewith the packages we just released[email protected])https://github.com/apollographql/router[email protected]supergraph composenatively on an M1, and in Docker on an M1rover@vNext!