Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate options #340

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Don't mutate options #340

merged 2 commits into from
Jun 30, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Jun 30, 2016 •
edited
Loading

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Fixes #339

@stubailo stubailo merged commit 387072e into master Jun 30, 2016
@zol zol removed the in progress label Jun 30, 2016
@stubailo stubailo deleted the no-option-mutation branch September 20, 2016 03:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stubailo @zol