Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for easy persistent configuration of apache #135

Closed
apolopena opened this issue May 10, 2021 · 0 comments
Closed

Allow for easy persistent configuration of apache #135

apolopena opened this issue May 10, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

Problem this feature will solve

Any changes made to the default apache config: /etc/apache2/apache2.conf does not persist.

Background

Proposed Solution

Implment the same system in place for persistent configuration of nginx. See the Constraints and Assumptions section

Constraints and Assumptions

From .gitpod.Dockerfile
COPY --chown=gitpod:gitpod .gp/conf/apache/apache2.conf /etc/apache2/apache2.conf

Alternatives or Workarounds

none really

Additional context

The user needs to break docker cache when updating apache config via .gp/conf/apache/apache2.conf

@apolopena apolopena added the enhancement New feature or request label May 10, 2021
@apolopena apolopena self-assigned this May 10, 2021
apolopena added a commit that referenced this issue May 10, 2021
@apolopena apolopena added in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels May 10, 2021
apolopena added a commit that referenced this issue May 10, 2021
* 🐛 FIX: #128

* 🐛 FIX: #127 and #128

* 🚀 RELEASE: bump version to 1.1.1

* Bump xdebug to 3.0.4 (#132)

* 🐛 FIX: #129

* 🐛 FIX: #129 missing code

* Fix  Issues 129  and 130 (#133)

* 🐛 FIX: #131

* 🐛 FIX: #130 opening url paths that end in a file name gives a 404

* 🤖 TEST: force Docker image build

* 💡 UPDATE COMMENTS: fix bad wording for include_readme

* 🐛 FIX: #134 and #135

* 🚀 RELEASE: bump gls version to 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant