Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting a workspaces gives an error when opening the preview #19

Closed
apolopena opened this issue Feb 3, 2021 · 12 comments
Closed

Restarting a workspaces gives an error when opening the preview #19

apolopena opened this issue Feb 3, 2021 · 12 comments
Assignees
Labels
bug Something isn't working internal-gitpod-bug Bug in the Gitpod platform itself passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main workaround-implemented

Comments

@apolopena
Copy link
Owner

apolopena commented Feb 3, 2021

Describe the bug

restarting a workspaces gives an intermittent error when opening the preview:

2021/02/03 16:16:18 error while issuing request: Post "http://localhost:23000/gitpod/cli": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
2021/02/03 16:16:53 error while issuing request: Post "http://localhost:23000/gitpod/cli": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Screenshots

Steps to reproduce

  1. create a new workspace
  2. stop the workspace
  3. restart the workspace

Expected behavior

There should be no errors

Additional information

Looks like the preview browser is trying to open again when its already open.

@apolopena apolopena added the bug Something isn't working label Feb 3, 2021
@apolopena apolopena self-assigned this Feb 3, 2021
@apolopena
Copy link
Owner Author

Seems to be intermittant. So far I can't replicate it.

@apolopena apolopena changed the title [BUG] restarting a workspaces gives an error when opening the preview Restarting a workspaces gives an error when opening the preview Feb 4, 2021
@apolopena
Copy link
Owner Author

The issue has disappeared. I will re-open it if anyone sees it again.

@apolopena
Copy link
Owner Author

seeing this again

@apolopena apolopena reopened this Feb 7, 2021
@apolopena apolopena added the internal-gitpod-bug Bug in the Gitpod platform itself label Feb 8, 2021
@apolopena
Copy link
Owner Author

Seems internal to gitpod. Will follow up later.

@apolopena
Copy link
Owner Author

See: gitpod-io/gitpod#3178

@apolopena
Copy link
Owner Author

The bug happens when gp preview is called from a 'reused' terminal on workspace restart and the browser is already open. This was hanging the spinner and genrally causing havok with the dely and multiple preview refresh.

I implemented a workaround that stops the spinner before the gp preview call, also I did away with the open preview function and just put the logic directly in .gitpod.yml. The result is no hung terminal and just one long delay and error message upon workspace restart when the browser window is already open. no errors seen so far upon workspace init.

Untested with VsCode as they are still working on implementing gp preview for VSCode.

error while issuing request: Post "http://localhost:23000/gitpod/cli": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

@apolopena
Copy link
Owner Author

Further tests show that the error happens even when the preview browser is closed before the workspace is stoped and then started again.
This is definitely a gitpod internal bug. I will keep it open but consider the bug worked around as best as possible which actaully is not t a very good user experience.

The only real workaround might be to only open the preview browser on init instead of trying to do it in a reused terminal on every workspace restart.

@apolopena
Copy link
Owner Author

Spinner no longer corrupts the terminal. Still odd behavior on workspace restart in the terminal that opens the preview however it is no longer fatal. Click into the terminal after some time if the terminal looses its prompt.

@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Mar 24, 2021
apolopena added a commit that referenced this issue Mar 24, 2021
* 📖 DOC: #58 Readme: Revamp and add TOC

* 🐛 FIX: #45

* 🤖 TEST: phpmyadmin

* 🐛 FIX: #45

* 🐛 FIX: path

* 🐛 FIX: typo in path

* 🐛 FIX: #45

* 🐛 FIX: remove quotes in sed for phpmyadmin

* 🤖 TEST: special chars

* 🤖 TEST: restore test back to dynamic state

* 🐛 FIX: phpmyadmin config

* 🐛 FIX: @ breaks things when generated string starts with one

* 🐛 FIX: create phpmyadmin db

* 🐛 FIX: spinner

* 🐛 FIX: #45

* 🐛 FIX: credentials

* 🐛 FIX: go back to cp of config.sample.inc.php

* 🤖 TEST: rsync progress

* 👌 IMPROVE: #62

* 🐛 FIX: tweak rsync progress

* 🐛 FIX: tweak rsync progress

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: rsync stats, restored spinner for speed

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: colorized rsync stats

* 🐛 FIX: log messages

* 👌 IMPROVE: remove auth, edit comments

* 👌 IMPROVE: Installtion information API for #61

* 📖 DOC: comments

* 🤖 TEST: call yarn installs less

* 🤖 TEST: call yarn installs less

* 🐛 FIX: refactor to save calls to yarn install

* 🐛 FIX: refactor to save calls to yarn install

* 🤖 TEST: refactor to save calls to yarn install

* 🐛 FIX: load spinner

* 🐛 FIX: error mix not found

* 🐛 FIX: tweak order

* 🐛 FIX: line 130: printf: --: invalid option

* 🐛 FIX: line 130: printf: --: invalid option

* 🐛 FIX: tweaks

* 🤖 TEST: fix npm error

* 🤖 TEST: error in npm when install react scaffolding

* 🤖 TEST: with no yarn run dev after node modules are installed

* 🤖 TEST: installs

* 🐛 FIX: tweaks for less npm installs can rless running of laravel mix

* 🤖 TEST: tweaks for installs

* 🐛 FIX: install info API, bad regexp

* 🐛 FIX: new logic for installs

* 🐛 FIX: run_laraval_mix_twice

* 🐛 FIX: run_laravel_mix twice in the wrong spot

* 🤖 TEST: run larvel mix twice

* 🤖 TEST: run larvel mix twice

* 🐛 FIX: fresh start on getting out of this hole

* 🤖 TEST: vue install

* 🤖 TEST: adding in laravel mix run when installing laravel/ui

* 🤖 TEST: adding in laravel mix run when installing laravel/ui, remove extraneous condition

* 🤖 TEST: no npm install after install of larvel/ui

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: react install

* 🤖 TEST: no front end scaffolding installs, still install node modules

* 🐛 FIX: typo

* 🤖 TEST: no front end scaffolding installs

* 🐛 FIX: conditional

* 📖 DOC: comments

* 🐛 FIX: make successes a silent log

* 🐛 FIX: install conditions, ready to test

* 📖 DOC: fixed and tested one-liners for project creation

* 🐛 FIX: typo in condition

* 🐛 FIX: install node modules blindly to avoid frontend scaffolding overwrite

* 🐛 FIX: remove uneccessary  function

* 🐛 FIX: phpmyadmin install

* 🐛 FIX: path to public/phpmyadmin/config.inc.php

* 👌 IMPROVE: enhanced phpmyadmin setup logic

* 👌 IMPROVE: #64 Support .starter.env for sensitive data like phpmyadmin credentials

* 🐛 FIX: refactor #64, works good

* 🐛 FIX: rename and fix

* 🐛 FIX: path

* 🐛 FIX: file name

* 📖 DOC: #66 Add phpMyAdmin section to README.md

* 👌 IMPROVE: no trailing newline for .txt files

* 👌 IMPROVE: #65 Add log message to summary

* 📖 DOC: improve message

* 📖 DOC: improve message

* 🐛 FIX: #67 'before' tasks should be logged to file but not to the console

* 👌 IMPROVE: log messages

* 👌 IMPROVE: #68 Add help alias

* 👌 IMPROVE: success messages are logged silently

* 👌 IMPROVE: add silent log

* 🐛 FIX: log messages

* 🐛 FIX: logs and comments

* 🐛 FIX: #63

* 🐛 FIX: #41 Rename test-app to laravel8-starter

* 🤖 TEST: force workspace image build

* 🐛 FIX: rsync path

* 🐛 FIX: log message

* 🐛 FIX: message

* 🐛 FIX: message

* 🐛 FIX: message

* 👌 IMPROVE: #39 Expand Gitlog with additional emoji and git aliases

* 🐛 FIX: #39 change add to ad, add noadd aliases

* 📖 DOC: update as per #39

* 🐛 FIX: summary message

* 🐛 FIX: messaging

* 🐛 FIX: #69

* 🐛 FIX: fine tune, logic and logs

* 🐛 FIX: wording

* 🐛 FIX: edit log message

* 🐛 FIX: alias: add changed to ad

* 🐛 FIX: log silent on env injection success

* 🐛 FIX: log msg

* 🤖 TEST: fix broken web preview spinner

* 🤖 TEST: fix for hung preview

* 👌 IMPROVE: hung preview fix

* 🤖 TEST: preview browser fix

* 🤖 TEST: phpmyadmin install=0

* ♻️ REFACTOR: preview browser

* 👌 IMPROVE: preview browser message

* 🐛 FIX: removed preview browser open msg since #19 is a gitpod internal bug

* 🤖 TEST: barebones install

* 🤖 TEST: changelog generator

* 🤖 TEST: force workspace image build

* 🤖 TEST: changelog generator

* ⚰️ REMOVE: workaround code for #46

* 🤖 TEST: force workspace image build

* 🐛 FIX: init scripts should not depend on eachothers success

* 🤖 TEST: force workspace image build

* 📖 DOC: edit and enhance README

* 🐛 FIX: removed ... from log messages
apolopena added a commit that referenced this issue Mar 24, 2021
* 📖 DOC: #58 Readme: Revamp and add TOC

* 🐛 FIX: #45

* 🤖 TEST: phpmyadmin

* 🐛 FIX: #45

* 🐛 FIX: path

* 🐛 FIX: typo in path

* 🐛 FIX: #45

* 🐛 FIX: remove quotes in sed for phpmyadmin

* 🤖 TEST: special chars

* 🤖 TEST: restore test back to dynamic state

* 🐛 FIX: phpmyadmin config

* 🐛 FIX: @ breaks things when generated string starts with one

* 🐛 FIX: create phpmyadmin db

* 🐛 FIX: spinner

* 🐛 FIX: #45

* 🐛 FIX: credentials

* 🐛 FIX: go back to cp of config.sample.inc.php

* 🤖 TEST: rsync progress

* 👌 IMPROVE: #62

* 🐛 FIX: tweak rsync progress

* 🐛 FIX: tweak rsync progress

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: rsync stats, restored spinner for speed

* 🐛 FIX: use native rsync progress option

* 🐛 FIX: colorized rsync stats

* 🐛 FIX: log messages

* 👌 IMPROVE: remove auth, edit comments

* 👌 IMPROVE: Installtion information API for #61

* 📖 DOC: comments

* 🤖 TEST: call yarn installs less

* 🤖 TEST: call yarn installs less

* 🐛 FIX: refactor to save calls to yarn install

* 🐛 FIX: refactor to save calls to yarn install

* 🤖 TEST: refactor to save calls to yarn install

* 🐛 FIX: load spinner

* 🐛 FIX: error mix not found

* 🐛 FIX: tweak order

* 🐛 FIX: line 130: printf: --: invalid option

* 🐛 FIX: line 130: printf: --: invalid option

* 🐛 FIX: tweaks

* 🤖 TEST: fix npm error

* 🤖 TEST: error in npm when install react scaffolding

* 🤖 TEST: with no yarn run dev after node modules are installed

* 🤖 TEST: installs

* 🐛 FIX: tweaks for less npm installs can rless running of laravel mix

* 🤖 TEST: tweaks for installs

* 🐛 FIX: install info API, bad regexp

* 🐛 FIX: new logic for installs

* 🐛 FIX: run_laraval_mix_twice

* 🐛 FIX: run_laravel_mix twice in the wrong spot

* 🤖 TEST: run larvel mix twice

* 🤖 TEST: run larvel mix twice

* 🐛 FIX: fresh start on getting out of this hole

* 🤖 TEST: vue install

* 🤖 TEST: adding in laravel mix run when installing laravel/ui

* 🤖 TEST: adding in laravel mix run when installing laravel/ui, remove extraneous condition

* 🤖 TEST: no npm install after install of larvel/ui

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: remove inistal npm install

* 🤖 TEST: react install

* 🤖 TEST: no front end scaffolding installs, still install node modules

* 🐛 FIX: typo

* 🤖 TEST: no front end scaffolding installs

* 🐛 FIX: conditional

* 📖 DOC: comments

* 🐛 FIX: make successes a silent log

* 🐛 FIX: install conditions, ready to test

* 📖 DOC: fixed and tested one-liners for project creation

* 🐛 FIX: typo in condition

* 🐛 FIX: install node modules blindly to avoid frontend scaffolding overwrite

* 🐛 FIX: remove uneccessary  function

* 🐛 FIX: phpmyadmin install

* 🐛 FIX: path to public/phpmyadmin/config.inc.php

* 👌 IMPROVE: enhanced phpmyadmin setup logic

* 👌 IMPROVE: #64 Support .starter.env for sensitive data like phpmyadmin credentials

* 🐛 FIX: refactor #64, works good

* 🐛 FIX: rename and fix

* 🐛 FIX: path

* 🐛 FIX: file name

* 📖 DOC: #66 Add phpMyAdmin section to README.md

* 👌 IMPROVE: no trailing newline for .txt files

* 👌 IMPROVE: #65 Add log message to summary

* 📖 DOC: improve message

* 📖 DOC: improve message

* 🐛 FIX: #67 'before' tasks should be logged to file but not to the console

* 👌 IMPROVE: log messages

* 👌 IMPROVE: #68 Add help alias

* 👌 IMPROVE: success messages are logged silently

* 👌 IMPROVE: add silent log

* 🐛 FIX: log messages

* 🐛 FIX: logs and comments

* 🐛 FIX: #63

* 🐛 FIX: #41 Rename test-app to laravel8-starter

* 🤖 TEST: force workspace image build

* 🐛 FIX: rsync path

* 🐛 FIX: log message

* 🐛 FIX: message

* 🐛 FIX: message

* 🐛 FIX: message

* 👌 IMPROVE: #39 Expand Gitlog with additional emoji and git aliases

* 🐛 FIX: #39 change add to ad, add noadd aliases

* 📖 DOC: update as per #39

* 🐛 FIX: summary message

* 🐛 FIX: messaging

* 🐛 FIX: #69

* 🐛 FIX: fine tune, logic and logs

* 🐛 FIX: wording

* 🐛 FIX: edit log message

* 🐛 FIX: alias: add changed to ad

* 🐛 FIX: log silent on env injection success

* 🐛 FIX: log msg

* 🤖 TEST: fix broken web preview spinner

* 🤖 TEST: fix for hung preview

* 👌 IMPROVE: hung preview fix

* 🤖 TEST: preview browser fix

* 🤖 TEST: phpmyadmin install=0

* ♻️ REFACTOR: preview browser

* 👌 IMPROVE: preview browser message

* 🐛 FIX: removed preview browser open msg since #19 is a gitpod internal bug

* 🤖 TEST: barebones install

* 🤖 TEST: changelog generator

* 🤖 TEST: force workspace image build

* 🤖 TEST: changelog generator

* ⚰️ REMOVE: workaround code for #46

* 🤖 TEST: force workspace image build

* 🐛 FIX: init scripts should not depend on eachothers success

* 🤖 TEST: force workspace image build

* 📖 DOC: edit and enhance README

* 🐛 FIX: removed ... from log messages

* 📖 DOC: Gitpod Caveats
@apolopena
Copy link
Owner Author

There are two decent workarounds for this issue until it is fixed by Gitpod.

  • Move the command gp await-port 8000 && gp preview $(gp url 8000) to the last piece of code executed from the init command.

Or

  • Remove the gp await-port 8000 && gp preview $(gp url 8000) from .gitpod.yml replace it with a port directive:
ports:
- port: 8000
  onOpen: open-preview

@apolopena
Copy link
Owner Author

I implmented a hotfix for gracefully handling the gp preview Gitpod internal error

command: |
      if bash .gp/bash/open-preview.sh; then exit; else bash .gp/bash/hotfix.sh; fi

@apolopena apolopena removed the awaiting-gitpod-internal-fix The issue will be addressed by the gitpod team label Apr 10, 2021
@apolopena
Copy link
Owner Author

Renamed hotfix.sh to patch-preview.sh

apolopena added a commit that referenced this issue Apr 26, 2021
* 🤖 TEST: force workspace image build

* 🐛 FIX: path to get_env_value'

* 🐛 FIX: path to get_env_value

* ⚰️ REMOVE: file associations hack for files with no extension

* ♻️ REFACTOR: location

* ⚰️ REMOVE: shellcheck

* ⚰️ REMOVE: commented out shellcheck extension

* ➕ ADD: alias to shellcheck .sh files

* 🐛 FIX: debconf (Dialog frontend will not work on a dumb terminal

* ✏️ FIX TYPO: missing install

* 🤖 TEST: quiet install of php-fpm

* 🤖 TEST: DEBIAN_FRONTEND=noninteractive to suppress debconf warnings

* 👌 IMPROVE: combined log file runs

* 🐛 FIX: start_apache path

* 🐛 FIX: debconf warning

* 🐛 FIX: debconf warning

* 🐛 FIX: debconf warning

* 🐛 FIX: exclude 1090,1091 from shellchecks

* 💡 UPDATE COMMENTS: force passing of shellcheck

* 🤖 TEST: passes shellcheck

* 🤖 TEST: passes schellcheck

* 🤖 TEST: changelog generator

* 🤖 TEST: force workspace image build

* 🐛 FIX: lint only scripts in .gp

* 👌 IMPROVE: best practice for setting root

* 🐛 FIX: #94 phpmyadmin wont display in an iframe

* 🐛 FIX: #94 phpmyadmin wont display in an iframe

* 🤖 TEST: fix for #95

* 🤖 TEST: fix for #95

* 🤖 TEST: fix for #95

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 🤖 TEST: fix 95 for spinner

* 👌 IMPROVE: display port number

* 🩹 TEMP FIX: revert to no color in spinner

* 👌 IMPROVE: clock spinner

* 👌 IMPROVE: dot spinner

* 👌 IMPROVE: speed

* 🤖 TEST: remove stop_spinner calls

* 🐛 FIX: added stop_spinner calls back in

* 👌 IMPROVE: added pipe spinner

* 👌 IMPROVE: back to dot spinner

* 🐛 FIX: #90 nginx server requires trailing slash for phpmyadmin url

* 👌 IMPROVE: port security

* 🐛 FIX: nginx to use .gp/conf/nginx.conf

* 🤖 TEST: force workspace image build

* 🐛 FIX: removed duplicate try_files for php locations

* 🤖 TEST: force workspace image build

* ⚰️ REMOVE: local nginx.conf load

* 🤖 TEST: force workspace image build

* 🐛 FIX: restore composer install phpmyadmin verbosity

* 🐛 FIX: spinner success DONE msg after successful phpmyadmin install

* 🐛 FIX: revert working version

* 🤖 TEST: force

* 🤖 TEST: no github-changelog-generator

* 🐛 FIX: phpmyadmin with or without trailing slash for phpmyadmin

* 🤖 TEST: force workspace

* 🐛 FIX: bad code

* 🐛 FIX: revert fix phpmyadmin install verbosity

* 🐛 FIX: revert to no phpmyadmin redirect for no traling slash

* 🐛 FIX: phpmyadmin verbose install

* 🤖 TEST: force workspace

* 🐛 FIX: ignore linter

* 🐛 FIX: spinner for phpmyadmin install

* 🐛 FIX: move root out of locations

* 🤖 TEST: force workspace

* 🐛 FIX: #90 and #96

* 🤖 TEST: force container build

* 🐛 FIX: silence gp output

* ⚰️ REMOVE: /dev/null for gp (didnt work)

* 📦 NEW: encapsulates preview logic

* 📦 NEW: encapsulate start server logic

* ♻️ REFACTOR: start server logic

* 🐛 FIX: help_update_pma_pws absolute path

* ➕ ADD:

* ➕ ADD: alias op, open or refreshes preview browser

* 🐛 FIX: workaround for failing gp open call, see #19

* 🐛 FIX: syntax for issue 19 workaround

* 🐛 FIX: hotfix workaround for #19

* 🐛 FIX: syntax

* 🐛 FIX: path to hotfix

* ➕ ADD: hotfix message

* 🐛 FIX: op absolute path

* 👌 IMPROVE: preview script can open path segments

* 🤖 TEST: force docker build

* 🐛 FIX: message

* 👌 IMPROVE: colorized message

* 🐛 FIX: aliases to ~/.bashrc.d

* 🤖 TEST: force docker build

* 🐛 FIX: try copy snippets to bashrc.d

* 🐛 FIX: removed line break

* 🐛 FIX: #98 and #93

* ✏️ FIX TYPO: missing $

* 🤖 TEST: force docker build

* 🐛 FIX: #99

* 🤖 TEST: fix #92

* 🤖 TEST: fix #92

* 🐛 FIX: symbolic link for xdebug php-fpm #92

* 🐛 FIX: missing sudo for #92

* ♻️ REFACTOR: moved xdebug conf to .gp/conf

* ♻️ REFACTOR: give nginx its own folder

* ♻️ REFACTOR: php-fpm moved to its own folder

* ♻️ REFACTOR: moved .editorconfig to .gp/config/editorconfig

* ♻️ REFACTOR: #98

* 🐛 FIX: path

* 📖 DOC: update pma pws aliase name

* ♻️ REFACTOR: pma pws alias names

* ⚰️ REMOVE: unused license header

* 🐛 FIX: nginx log monitor

* 🤖 TEST: force docker build

* 🐛 FIX: phpmyadmin log msg

* 👌 IMPROVE: support colorized pma pws help msg

* support colorized messages

* 🐛 FIX: #100 lint-starter-scripts has no success message

* 🤖 TEST: force docker build

* 🐛 FIX: shorten alias name to lint-starter

* 🤖 TEST: force docker build

* 🐛 FIX: swap shellcheck install from brew to apt-get

* 🤖 TEST: turn colors back on to test gitpod-io/gitpod#3870

* 🤖 TEST: turn off colors, issue remains gitpod-io/gitpod#3870

* 🤖 TEST: laravel 7

* 🤖 TEST: force docker build

* 🤖 TEST: laravel 6

* 🤖 TEST: force docker build

* 🤖 TEST: react

* 🤖 TEST: laravel 7

* 🤖 TEST: force docker

* 🤖 TEST: no react

* 🤖 TEST: laravel 5

* 👌 IMPROVE: #102 Make the version of Laravel configurable in starter.ini

* 🤖 TEST: force docker build

* 🤖 TEST: configure laravel to version 7.*

* 🐛 FIX: gitpod-laravel8-starter to gitpod-laravel-starter

* 🐛 FIX: make rsync scaffolding laravel version agnostic

* 🤖 TEST: force docker build

* 🐛 FIX: path to artisan

* 💡 UPDATE COMMENTS: rules for setting laravel version

* 🐛 FIX: wiring in #101 Support Laravel 5, 6 and 7

* 🤖 TEST: force docker build

* 🤖 TEST: react

* 💡 UPDATE COMMENTS: more rules for laravel version directive

* 🤖 TEST: laravel 6

* 💡 UPDATE COMMENTS: laravel version rules wording

* 🐛 FIX: handle cases for laravel major version set to 5 in starter.ini

* 🤖 TEST: force docker build

* 🐛 FIX: path to laravel-js-2space

* 🤖 TEST: laravel 5

* 🐛 FIX: warning color

* 🐛 FIX: log message for laravel 5 and front end scaffolding

* 🤖 TEST: vue

* 🤖 TEST: vue auth

* 🤖 TEST: laravel 5.5.*

* 🤖 TEST: force docker build

* 🤖 TEST: laravel 6

* 💡 UPDATE COMMENTS: log messages

* ♻️ REFACTOR: move auth directives to top level

* 👌 IMPROVE: #105 Provide a Vue EXAMPLE

* 🤖 TEST: no vue or vue auth

* 🤖 TEST: laravel 7.*

* 🤖 TEST: laravel 8.*

* 🤖 TEST: laravel 8.*

* 🤖 TEST: laravel 6.0.0

* 🐛 FIX: log msg for using laravel version out of range

* 🤖 TEST: #107

* ♻️ REFACTOR: drop support for Laravel 5

* 🐛 FIX: example initializes when it should be skipped

* 🐛 FIX: workaround trailing slash rewrite does not wotk in an iframe for nginx

* 🤖 TEST: laravel 8.*

* 🤖 TEST: force docker build

* 🤖 TEST: phpmyadmin

* 🤖 TEST: force docker build

* 🐛 FIX: phpmyadmin was ignored when not using an EXAMPLE

* 🤖 TEST: force

* 🐛 FIX: phpmyadmin was ignored when not using an EXAMPLE

* 🤖 TEST: force

* 🐛 FIX: abort with error msg if not run from the project root

* 💡 UPDATE COMMENTS: update  laravel version rules

* 🐛 FIX: pass linter

* 🐛 FIX: only allow laravel version values 6.* 7.* or 8.*

* 🤖 TEST: force

* 🤖 TEST: invalid laravel version

* ⚰️ REMOVE: test code

* 🤖 TEST: force

* ⚰️ REMOVE: invalid laravel version value

* 💡 UPDATE COMMENTS: typo

* 💡 UPDATE COMMENTS: END block

* 👌 IMPROVE: #109 allow_mixed_web starter.ini config

* 🐛 FIX: #109 allow_mixed_web starter.ini config

* 💡 UPDATE COMMENTS: fixed path

* 🐛 FIX: bypass allow-mixed-web injection if file has already been injected

* 🐛 FIX: add linebreak

* 🐛 FIX: pass dev qa for #109 allow_mixed_web directive in starter.ini

* 🐛 FIX: cases where frontend is already in vcs and case where exmaple is request but laravel is already installed

* 🐛 FIX: hook for laravel scaffolding in VCS

* 🐛 FIX: missing shebang

* 👌 IMPROVE: install npm ^7

* 🐛 FIX: log msg

* 🤖 TEST: laravel 7.*

* 🐛 FIX: update npm to ^7

* 🤖 TEST: laravel 6.*

* 🤖 TEST: force

* 🐛 FIX: powered by summary

* 🐛 FIX: pass linter and add woman technologist

* 🤖 TEST: no installs

* 🐛 FIX: #111

* 🤖 TEST: force

* ⚰️ REMOVE: extraneous message

* 🐛 FIX: laravel_version no longer uses starter.ini

* ♻️ REFACTOR: rename hotfix to hotfix #19

* 🐛 FIX: rolling in QAed changes from other branches

* 🐛 FIX: rolling in QAed changes from other branches

* 📖 DOC: #85 #97 #103

* ✏️ FIX TYPO: superseded to superceded

* ➕ ADD: missing code from QAed branch

* 🐛 FIX: revert to defaults

* ⚰️ REMOVE: extra linebreak

* ⚰️ REMOVE: extra space

* 🐛 FIX: gracefully handle laravel version mismatches

* ♻️ REFACTOR: rename hotfix19.sh to patch-preview.sh

* 🐛 FIX: change log message for successful laravel .env injection

* 🐛 FIX: update summary message

* 🐛 FIX: wording for summary

* 🐛 FIX: remove package-lock.json, this is a yarn based project

* ➕ ADD: success and error logs for instaling github-changelog-generator

* 🐛 FIX: notify user when vue install directive was found but intentionally skipped

* ✏️ FIX TYPO: missing the word is

* 🐛 FIX: change verbose short option from -v to -V

* ♻️ REFACTOR: move cleanup, re order tasks, edit comments

* 🐛 FIX: update comments and log message

* 💡 UPDATE COMMENTS: edit/add comments

* ➕ ADD: license URL

* ⚰️ REMOVE: extra linebreak

* 💡 UPDATE COMMENTS: edit wording

* 💡 UPDATE COMMENTS: edit/add wording

* 🐛 FIX: linebreaks in show_first_run_summary

* 🐛 FIX: missing logger

* 💡 UPDATE COMMENTS: edit/add wording

* ♻️ REFACTOR: show_powered_by: alternate vue version location for version >2

* 🐛 FIX: remove directive to configure vue version, too many edge cases to support

* 🤖 TEST: vue install when using laravel 6.*

* 🐛 FIX: install vue regardless of laravel version

* 🤖 TEST: restore defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal-gitpod-bug Bug in the Gitpod platform itself passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main workaround-implemented
Projects
None yet
Development

No branches or pull requests

2 participants