Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues 129 and 130 #133

Merged
merged 2 commits into from
May 10, 2021
Merged

Fix Issues 129 and 130 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2fec7
🐛 FIX: https://github.com/apolopena/gitpod-laravel-starter/issues/131
apolopena May 10, 2021
9bc2cc0
🐛 FIX: https://github.com/apolopena/gitpod-laravel-starter/issues/130…
apolopena May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .gp/bash/open-preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,8 @@ exit 1

. .gp/bash/spinner.sh

__path=
if [[ -n $1 ]]; then
if [[ ! $1 =~ \/$ ]]; then
__path=/$1/
else
__path=/$1
fi
fi
__path=/$1

__port=$(bash .gp/bash/helpers.sh get_default_server_port)
if [[ $(bash .gp/bash/helpers.sh is_inited) == 0 ]]; then
. .gp/bash/spinner.sh &&
Expand Down
4 changes: 3 additions & 1 deletion .gp/conf/nginx/nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ http {
index index.html index.htm index.php;
# Bugfix: https://github.com/apolopena/gitpod-laravel-starter/issues/96
# Rewrite urls that dont have a trailing slash to have a trailing slash thus bypassing redirection.
# Bugfix: https://github.com/apolopena/gitpod-laravel-starter/issues/131
# force rewrite to use https in order to bypass mixed content errors when in an iframe
if (-d $request_filename) {
rewrite [^/]$ $scheme://$http_host$uri/ permanent;
rewrite [^/]$ https://$http_host$uri/ permanent;
}
try_files $uri $uri/ /index.php$is_args$args;
}
Expand Down