Another case of bad markup identified in Issue#549. Closing tags without having opening tags. Test cases also added.

[kedarchandrayan]

Summary

Closes #549

What are the specific steps to test this change?

The snippets given in the issues should now work as expected.

What kind of change does this PR introduce?

(Check at least one)

• Bug fix
• New feature
• Refactor
• Documentation
• Build-related changes
• Other

Make sure the PR fulfills these requirements:

• It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
• The changelog is updated
• Related documentation has been updated
• Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[kedarchandrayan]

Hello Team,
cc: @boutell

Please review this change and let me know your comments.

Thanks in advance!
Kedar Chandrayan

[boutell]

I think the current code tolerates markup like this:

<div>
<p>
<p>
<p>
</div>

I think your change would break that which is too strict (a backwards compatibility break). Please add unit tests confirming if you think it won't be a problem.

Also:

<div>
<br />
<br />
<br />
</div>

I'm not sure if these self-closing tags go on the stack or not.

[kedarchandrayan]

Hello @boutell,

Thank you for the feedback. Following is my response, point-wise.

Markup like the following works fine, even after the change. htmlparser2 gives callbacks for both onopentag and onclosetag for the p tags, even if the closing p tags are not present.

<div>
<p>
<p>
<p>
</div>

I have added 2 test cases for the above markup as asked by you.

For self-closing tags, htmlparser2 gives consecutive callbacks for onopentag and onclosetag. For these, the tag goes in the stack and gets popped immediately. So these will also work with the change made.

Please let me know if anything else is needed from my end.

Thanks,
Kedar Chandrayan

[boutell]

Thanks!

[kedarchandrayan]

Thank you @boutell 🙏