Adding tests for Merge Request Manager

reconcile/templating/lib/merge_request_manager.py

@@ -40,7 +40,7 @@
 
 {DATA_SEPARATOR}
 
-* {VERSION_REF}: {TR_VERSION}
+* {VERSION_REF}: $version
 * {COLLECTION_REF}: $collection
 * {TEMPLATE_HASH_REF}: $template_hash
 """
@@ -89,8 +89,12 @@ def parse(self, description: str) -> TemplateInfo:
         )
 
 
-def render_description(collection: str, template_hash: str) -> str:
-    return MR_DESC.substitute(collection=collection, template_hash=template_hash)
+def render_description(
+    collection: str, template_hash: str, version: str = TR_VERSION
+) -> str:
+    return MR_DESC.substitute(
+        collection=collection, template_hash=template_hash, version=version
+    )
 
 
 def render_title(collection: str) -> str:

reconcile/test/templating/lib/test_merge_request_manager.py

@@ -0,0 +1,167 @@
+from unittest.mock import Mock
+
+import pytest
+from build.lib.reconcile.utils.vcs import VCS
+from gitlab.v4.objects import ProjectMergeRequest
+from pytest_mock import MockerFixture
+
+from reconcile.templating.lib.merge_request_manager import (
+    TR_LABEL,
+    MergeRequestManager,
+    OpenMergeRequest,
+    Parser,
+    TemplateInfo,
+    TemplateRenderingMR,
+    render_description,
+)
+from reconcile.templating.lib.model import TemplateInput, TemplateOutput
+from reconcile.utils.gitlab_api import GitLabApi
+
+
+@pytest.fixture
+def gitlab_cli(mocker: MockerFixture) -> GitLabApi:
+    return mocker.MagicMock(GitLabApi)
+
+
+@pytest.fixture
+def mergereqeustmanager(mocker: MockerFixture) -> tuple[MergeRequestManager, Mock]:
+    vcs = mocker.MagicMock(VCS)
+    return MergeRequestManager(vcs, Parser()), vcs
+
+
+def test_parser_parse() -> None:
+    # TODO: just a simple test, cause want to reusae other parser classes later
+    collection = "foo bar"
+    shasum = "e8460885f1031d12f4853a4fe0ebf9680c7d82ff21e2159fd89a3983f853203f"
+
+    t = Parser().parse(render_description(collection, shasum))
+    assert t.collection == collection
+    assert t.template_hash == shasum
+
+
+@pytest.mark.parametrize("is_new,create,update", [(True, 1, 0), (False, 0, 1)])
+def test_templaterenderingmr_process_updated(
+    is_new: bool, create: int, update: int, gitlab_cli: Mock
+) -> None:
+    trm = TemplateRenderingMR(
+        "title",
+        "description",
+        [TemplateOutput(is_new=is_new, content="", path="")],
+        ["label"],
+    )
+    trm.process(gitlab_cli)
+
+    assert gitlab_cli.create_file.call_count == create
+    assert gitlab_cli.update_file.call_count == update
+
+
+def test_create_tr_merge_request_fail(
+    mergereqeustmanager: tuple[MergeRequestManager, Mock],
+) -> None:
+    with pytest.raises(AssertionError):
+        mergereqeustmanager[0].create_tr_merge_request(
+            [TemplateOutput(is_new=True, content="", path="")],
+        )
+
+
+def test_create_tr_merge_request_create(
+    mergereqeustmanager: tuple[MergeRequestManager, Mock],
+) -> None:
+    mrm, vcs = mergereqeustmanager
+    mrm.create_tr_merge_request(
+        [
+            TemplateOutput(
+                input=TemplateInput(collection="foo", template_hash="abc"),
+                is_new=True,
+                content="",
+                path="",
+            )
+        ],
+    )
+
+    vcs.open_app_interface_merge_request.assert_called_once()
+
+
+@pytest.mark.parametrize("thash,closed", [("cba", True), ("abc", False)])
+def test_create_tr_merge_request_found(
+    thash: str,
+    closed: bool,
+    mergereqeustmanager: tuple[MergeRequestManager, Mock],
+    mocker: MockerFixture,
+) -> None:
+    mrm, vcs = mergereqeustmanager
+    mrm._open_mrs.append(
+        OpenMergeRequest(
+            raw=mocker.patch("gitlab.v4.objects.ProjectMergeRequest", autospec=True),
+            template_info=TemplateInfo(collection="foo", template_hash=thash),
+        )
+    )
+    mrm.create_tr_merge_request(
+        [
+            TemplateOutput(
+                input=TemplateInput(collection="foo", template_hash="abc"),
+                is_new=True,
+                content="",
+                path="",
+            )
+        ],
+    )
+    if closed:
+        vcs.close_app_interface_mr.assert_called_once()
+    else:
+        vcs.close_app_interface_mr.assert_not_called()
+    vcs.open_app_interface_merge_request.assert_not_called()
+
+
+@pytest.mark.parametrize(
+    "attributes,closed_reason",
+    [
+        (
+            {
+                "description": render_description("foo", "abc"),
+                "has_conflicts": False,
+            },
+            "",
+        ),
+        (
+            {
+                "description": "description",
+                "has_conflicts": True,
+            },
+            "Closing this MR because of a merge-conflict.",
+        ),
+        (
+            {
+                "description": render_description("foo", "abc", version="fooo"),
+                "has_conflicts": False,
+            },
+            "Closing this MR because it has an outdated integration version",
+        ),
+        (
+            {
+                "description": "foo-bar",
+                "has_conflicts": False,
+            },
+            "Closing this MR because of bad description format.",
+        ),
+    ],
+)
+def test_housekeeping(
+    attributes: dict,
+    closed_reason: str,
+    mergereqeustmanager: tuple[MergeRequestManager, Mock],
+    mocker: MockerFixture,
+) -> None:
+    mrm, vcs = mergereqeustmanager
+    mr = mocker.MagicMock(ProjectMergeRequest)
+    mr.labels = [TR_LABEL]
+    mr.attributes = attributes
+    vcs.get_open_app_interface_merge_requests.return_value = [mr]
+    mrm._open_mrs = []
+    mrm.housekeeping()
+    if closed_reason:
+        vcs.close_app_interface_mr.assert_called_with(mr, closed_reason)
+    else:
+        vcs.close_app_interface_mr.assert_not_called()
+        assert mrm._open_mrs[0].raw == mr
+        assert mrm._housekeeping_ran