Merge pull request #4 from appfolio/prevent-name-error-on-test-case-d…

…ecode Capture NameError when decoding test case name
appfolio · Apr 7, 2019 · 28a1c97 · 28a1c97
2 parents a7d3072 + 86a5001
commit 28a1c97
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/parallel_tests/fine_grain_test/test_case.rb b/lib/parallel_tests/fine_grain_test/test_case.rb
@@ -9,7 +9,12 @@ def self.encode(test_case)
       def self.decode(string)
         suite, name = string.split(/ /, 2)
         name = name.gsub("\\n", "\n").gsub("\\\\", "\\")
-        new(Object.module_eval("::#{suite}", __FILE__, __LINE__), name)
+        suite_object = begin
+                         Object.module_eval("::#{suite}", __FILE__, __LINE__)
+                       rescue NameError
+                         nil
+                       end
+        new(suite_object, name) if suite_object
       end
 
       def ==(other)

diff --git a/test/parallel_tests/fine_grain_test/test_case_test.rb b/test/parallel_tests/fine_grain_test/test_case_test.rb
@@ -48,6 +48,12 @@ def test_decode__should_handle_backslashes
         assert_equal self.class, test_case.suite
         assert_equal "hello\\there", test_case.name
       end
+
+      def test_decode__should_return_nil_when_suite_is_not_defined
+        str = "ParallelTests::FineGrainTest::DoesNotExist hello\\\\there"
+
+        assert_nil TestCase.decode(str)
+      end
     end
   end
 end