fixed joins association #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Would you mind adding a test for this change? |
stasl
force-pushed
the
master
branch
4 times, most recently
from
836ca16 to
0858602
Compare
stasl
force-pushed
the
master
branch
2 times, most recently
from
1167b19 to
65d7690
Compare
|
@jonkessler I have added spec and few more fixes, please check |
| else | ||
| klass.send(:build_default_scope, ActiveRecord::Relation.create(klass, table)) | ||
| end | ||
| scope_chain_items.concat [default_scope].compact |
There was a problem hiding this comment.
Is this change in Rails 4.1.x somewhere?
There was a problem hiding this comment.
yes, method signature was change in 4.1.x, then added default parameter.
specs failed for that versions, this is how I discovered
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.