Add patch for Rails 5.2.x

[n-rodriguez]

No description provided.

[johndobrien]

It would be wonderful if this could be accepted.

[n-rodriguez]

@jonkessler
Hi! Rails 5.2 is out :) http://weblog.rubyonrails.org/
I think we could drop support of Rails 4.0.x and 4.1.x in this new release. What do you think?

[bboe]

Given the addition of the polymorphic_name method, I'm wondering if this package is even necessary in rails5. Or to ease transition, perhaps we need only overwrite that method going forward.

https://github.com/rails/rails/blob/d35875b7a3f559155a9378cbe9203b0b8ea580f9/activerecord/lib/active_record/inheritance.rb#L159

[n-rodriguez]

Given the addition of the polymorphic_name method, I'm wondering if this package is even necessary in rails5

yeah... wondering the same

[n-rodriguez]

Actually this gem is useless for Rails 5.2 but not for Rails 5.1 and before.
Rails 5.1 : https://github.com/rails/rails/blob/5-1-stable/activerecord/lib/active_record/inheritance.rb
Rails 5.2 : https://github.com/rails/rails/blob/5-2-stable/activerecord/lib/active_record/inheritance.rb

[bboe]

@n-rodriguez would you consider updating your pull request such that for rails 5.2 only the polymorphic_name method is updated? It'd be nice to know that all the tests pass with such a simple change. In a subsequent pull request we could even go so far as to output a deprecation warning suggesting how to make it so this gem isn't necessary.

Thanks again for the efforts!

[n-rodriguez]

I'm on it ;)

[n-rodriguez]

2 tests are broken :

  1) Failure:
TestStoreBaseStiClass#test_polymorphic_has_many_through_with_double_sti_on_join_model [/home/nicolas/PROJECTS/GITHUB/store_base_sti_class/test/test_store_base_sti_class.rb:145]:
Expected: "SpecialPost"
  Actual: "Post"

  2) Failure:
TestStoreBaseStiClass#test_has_many_through_polymorphic_has_one [/home/nicolas/PROJECTS/GITHUB/store_base_sti_class/test/test_store_base_sti_class.rb:116]:
--- expected
+++ actual
@@ -1 +1 @@
-[#<Tagging id: 14, tag_id: 20, polytag_id: nil, polytag_type: nil, taggable_type: "Post", taggable_id: 21>, #<Tagging id: 15, tag_id: 20, polytag_id: nil, polytag_type: nil, taggable_type: "SpecialPost", taggable_id: 22>]
+[#<Tagging id: 14, tag_id: 20, polytag_id: nil, polytag_type: nil, taggable_type: "Post", taggable_id: 21>]

[bboe]

2 tests are broken

Thanks for looking into that. Can we isolate the changes that are needed to get those to work?

[n-rodriguez]

Thanks for looking into that. Can we isolate the changes that are needed to get those to work?

Done!

[bboe]

Awesome. Taking a look. Edit, heading home. I'll take a look tomorrow morning. Thanks for the updates.

[bboe]

Thanks for submitting! You're awesome. 🎆

[n-rodriguez]

You're welcome :)

[bboe]

Released 1.2.0.