Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to provide a 'size' attribute on the modal cmp. #35

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

mbowen000
Copy link
Contributor

Hey Strike Team!

Not sure if I'm missing anything big for testing this but it's a simple change. I wanted to have support for large modals in my project (without overriding CSS), so I created this simple change. I'm not a big OSS contributor so hopefully I'm not missing anything big here!

  • Supply a "size" attribute (optional). Right now the only supported SLDS modal size variant is "large"
  • This will add the slds-modal_large class onto the div.slds-modal element

I only tested that it works with it on and off. I did not see anything else that would be impacted by this feature, but let me know if you would like to see anything else! Thanks!

@mbowen000 mbowen000 changed the base branch from master to testing June 21, 2017 14:55
@kevinberonilla kevinberonilla merged commit 1124bbf into appiphony:testing Jul 11, 2017
@mbowen000 mbowen000 deleted the modal-size-support branch August 17, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants