Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed "element" property, added complete information about element #808

Merged
merged 5 commits into from
Nov 16, 2023
Merged

feat: changed "element" property, added complete information about element #808

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1384f3c
Feat: changed "element" property, added complete information about el…
IlyaUA Nov 9, 2023
152e9de
Returned the previous accessibility result fields, changed the snapsh…
IlyaUA Nov 10, 2023
3ab6431
Merge branch 'master' into accessibility-audit-improvements
IlyaUA Nov 10, 2023
b9a3ed0
Moved extracting the element into a separate variable
IlyaUA Nov 14, 2023
2a0d657
Minor refactoring, property names changed.
IlyaUA Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions WebDriverAgentLib/Categories/XCUIApplication+FBHelpers.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,12 +369,14 @@ - (BOOL)fb_dismissKeyboardWithKeyNames:(nullable NSArray<NSString *> *)keyNames
if (nil != auditTypeValue) {
auditType = valuesToNamesMap[auditTypeValue] ?: [auditTypeValue stringValue];
}
id<FBXCElementSnapshot> snapshot = [extractIssueProperty(issue, @"element") lastSnapshot];
IlyaUA marked this conversation as resolved.
Show resolved Hide resolved
NSDictionary *element = snapshot ? [self.class dictionaryForElement:snapshot recursive:NO] : @{};

[resultArray addObject:@{
@"detailedDescription": extractIssueProperty(issue, @"detailedDescription") ?: @"",
@"compactDescription": extractIssueProperty(issue, @"compactDescription") ?: @"",
@"auditType": auditType,
@"element": [extractIssueProperty(issue, @"element") description] ?: @"",
@"elementDescription": [extractIssueProperty(issue, @"element") debugDescription] ?: @"",
@"element": element ?: @{},
IlyaUA marked this conversation as resolved.
Show resolved Hide resolved
}];
return YES;
};
Expand Down
Loading