Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add idleTimeoutMs param to the openUrl call #933

Merged
merged 2 commits into from
Aug 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions WebDriverAgentLib/Commands/FBSessionCommands.m
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ + (NSArray *)routes
return FBResponseWithStatus([FBCommandStatus invalidArgumentErrorWithMessage:@"URL is required" traceback:nil]);
}
NSString* bundleId = request.arguments[@"bundleId"];
NSNumber* idleTimeoutMs = request.arguments[@"idleTimeoutMs"];
NSError *error;
if (nil == bundleId) {
if (![XCUIDevice.sharedDevice fb_openUrl:urlString error:&error]) {
Expand All @@ -76,6 +77,10 @@ + (NSArray *)routes
if (![XCUIDevice.sharedDevice fb_openUrl:urlString withApplication:bundleId error:&error]) {
return FBResponseWithUnknownError(error);
}
if (idleTimeoutMs.doubleValue > 0) {
XCUIApplication *app = [[XCUIApplication alloc] initWithBundleIdentifier:bundleId];
[app fb_waitUntilStableWithTimeout:FBMillisToSeconds(idleTimeoutMs.doubleValue)];
}
}
return FBResponseWithOK();
}
Expand Down
Loading