Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Java recorder syntax for executeScript #1161

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: update Java recorder syntax for executeScript #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/renderer/lib/client-frameworks/java.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,12 @@ driver.perform(Arrays.asList(swipe));
if (jsonArg === undefined) {
assembledCommand = `driver.executeScript("${scriptCmd}");`;
} else {
// change the JSON object into a format accepted by Map.ofEntries:
// combine the keys and values into a flattened array
const argsValuesArray = _.flatMap(_.toPairs(JSON.parse(jsonArg)));
// stringify the array and remove its square brackets
const argsValuesString = JSON.stringify(argsValuesArray).slice(1, -1);
assembledCommand = `driver.executeScript("${scriptCmd}", ImmutableMap.ofEntries(${argsValuesString}));`;
// change the JSON object into a format accepted by Map.ofEntries: a sequence of Map.entry(key, value)
// first create an array for each key-value pair
const argsValuesArray = _.toPairs(JSON.parse(jsonArg));
// then wrap each key-value array in Map.entry()
const argsValuesStrings = argsValuesArray.map((kv) => `Map.entry(${JSON.stringify(kv).slice(1, -1)})`);
assembledCommand = `driver.executeScript("${scriptCmd}", Map.ofEntries(${argsValuesStrings.join(', ')}));`;
}
return assembledCommand;
}
Expand Down