refactor: update Crowdin API to v2 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Nov 5, 2023
KazuCocoa
approved these changes
Nov 5, 2023
eglitise
reviewed
Nov 5, 2023
There was a problem hiding this comment.
Thanks!
I noticed that Crowdin also has their own JS client (https://github.com/crowdin/crowdin-api-client-js), maybe it could simplify some parts of the code? It could even be added to devDependencies instead of dependencies.
I am usually not a big fan of adding new dependencies in case the original implementation is simple and does not require a lot of boilerplate code. |
eglitise
approved these changes
Nov 6, 2023
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
laib3
pushed a commit
to laib3/appium-inspector
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1115
Also replaced long-time-deprecated request libs with axios