feat: add support for export/import actions in json format #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
eglitise
requested changes
Jun 8, 2024
There was a problem hiding this comment.
Thank you!🙏 I will test this later, but looks great!
If it's not too much, could you please also update the documentation? Specifically, I'm referring to the top image and Saved Gestures section here: https://appium.github.io/appium-inspector/latest/session-inspector/gestures/
github-actions
bot
added
the
documentation
eglitise
reviewed
Jun 9, 2024
eglitise
requested changes
Jun 17, 2024
|
@eglitise Thank you for the feedback. I was occupied with other tasks and was unable to address the comments earlier. I will prioritize these items and aim to complete them within this week. |
sudharsan-selvaraj
force-pushed
the
feat/843
branch
from
59885a0 to
1a2e40e
Compare
github-actions
bot
added
the
dependencies
sudharsan-selvaraj
force-pushed
the
feat/843
branch
from
534ecff to
0dbf16f
Compare
eglitise
reviewed
Aug 19, 2024
| @@ -16,6 +17,7 @@ import { | |||
| } from '../utils/source-parsing'; | |||
| import {log} from '../utils/logger'; | |||
| import {showError} from './Session'; | |||
| import {SAVED_FRAMEWORK, SET_SAVED_GESTURES} from '../../shared/setting-defs'; | |||
There was a problem hiding this comment.
This was accidentally removed from line 4 and re-added here :)
eglitise
approved these changes
Aug 19, 2024
|
Also there's some stray changes in |
|
Thanks again for implementing this! 👍 |
laib3
pushed a commit
to laib3/appium-inspector
that referenced
this pull request
Nov 16, 2024
) * add file saver dependency * feat: add support for export/import actions in json format * Use native file download instead of file-saver * remove file-save from dependencies * Update docs with latest changes * doc update * Add detailed errors for invalid json files * Fix formatting * Fix import order * CR comment fixes * Fix typo * Code review fixes * update icon * fix linting and styling * Fix sugggestions * avoid state mutation with duplicate actions * fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #843