Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more eslint rules #1675

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

eglitise
Copy link
Collaborator

Here are a few enhancements to the ESLint configuration, since it was recently edited for migration to flat config:

  • Use React plugin's jsx-runtime config and remove the React exclusion for no-unused-vars. This allowed the removal of all the empty import React from 'react'; lines, which also reduced the production app bundle size.
  • Add a plugin for sorting imports. A while back, a Prettier plugin was used to achieve this, but this approach is simpler.

@github-actions github-actions bot added chore Internal changes not visible to the user dependencies Dependency updates, removals or additions labels Sep 10, 2024
@eglitise eglitise merged commit 416e581 into appium:main Sep 10, 2024
7 checks passed
@eglitise eglitise deleted the more-linting-rules branch September 10, 2024 18:51
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
* chore: remove empty React imports

* chore: add eslint import sorting plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user dependencies Dependency updates, removals or additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants